Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We just get an indefinite spinner, and a JS error.
Turns out the issue is menu toggle checks the Drupal.settings['adaptivetheme'][activeTheme] structure, but this isn't added to the modal AJAX request so fails with an undefined variable error.
Attached patch just bails if this structure is not set, which seems reasonable since there aren't actually any menus on the media modal "edit" dialog.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2102419-menu-toggle-media-modal.patch | 600 bytes | Owen Barton |
menu-toggle-media-modal.patch | 588 bytes | Owen Barton |
Comments
Comment #1
Owen Barton CreditAttribution: Owen Barton commentedFixed patch
Comment #2
Jeff Burnz CreditAttribution: Jeff Burnz commentedOK, seems pretty simple, will test as soon as I get time, if anyone else can and RTBC I am cool with committing it.
As you can see its taken me over two weeks to make this one comment, so any help like this is massively appreciated!
Comment #2.0
Jeff Burnz CreditAttribution: Jeff Burnz commentedFix typo
Comment #3
Jeff Burnz CreditAttribution: Jeff Burnz commentedCommitted! Thank-you for your contribution, I attributed you also. Cheers!