Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

Status: Active » Needs review
FileSize
2.31 KB

At least this

andypost’s picture

The right test

andypost’s picture

Priority: Normal » Major

Suppose this major because testing broken

larowlan’s picture

+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

$current_user->id() instead?

andypost’s picture

+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $current_user = $this->container->get('current_user')->id();
...
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

probably better name it $current_user_id

andypost’s picture

Tune this up

larowlan’s picture

Status: Needs review » Reviewed & tested by the community

Unless bot disagrees

andypost’s picture

andypost’s picture

messed patches, fail patch with test only

larowlan’s picture

Still RTBC but now demonstrates failing HEAD.
Great work.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2d10571 and pushed to 8.x. Thanks!

Berdir’s picture

Great to see this fixed, but it wasn't really a bug... This never worked with global $user either.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.