Files: 
CommentFileSizeAuthor
#9 drupal8.simpletest-module.2102539-9-fail.patch1.91 KBandypost
FAILED: [[SimpleTest]]: [MySQL] 58,810 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#9 drupal8.simpletest-module.2102539-8.patch2.86 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 58,700 pass(es).
[ View ]
#8 drupal8.simpletest-module.2102539-8-fail.patch964 bytesandypost
PASSED: [[SimpleTest]]: [MySQL] 58,685 pass(es).
[ View ]
#8 drupal8.simpletest-module.2102539-8.patch2.86 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 58,682 pass(es).
[ View ]
#6 interdiff.txt1.97 KBandypost
#6 drupal8.simpletest-module.2102539-6.patch2.86 KBandypost
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
#2 drupal8.simpletest-module.2102539-2.patch2.31 KBandypost
PASSED: [[SimpleTest]]: [MySQL] 58,277 pass(es).
[ View ]
#1 drupal8.simpletest-module.2102539-1.patch2.31 KBandypost
FAILED: [[SimpleTest]]: [MySQL] 58,736 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.31 KB
FAILED: [[SimpleTest]]: [MySQL] 58,736 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

At least this

StatusFileSize
new2.31 KB
PASSED: [[SimpleTest]]: [MySQL] 58,277 pass(es).
[ View ]

The right test

Priority:Normal» Major

Suppose this major because testing broken

+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

$current_user->id() instead?

+++ b/core/modules/simpletest/lib/Drupal/simpletest/Tests/SimpleTestTest.php
@@ -64,8 +64,11 @@ function testInternalBrowser() {
+      $current_user = $this->container->get('current_user')->id();
...
+      $this->assertNotEqual($current_user, $this->container->get('current_user')->id(), 'Current user service updated.');

probably better name it $current_user_id

StatusFileSize
new2.86 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new1.97 KB

Tune this up

Status:Needs review» Reviewed & tested by the community

Unless bot disagrees

StatusFileSize
new2.86 KB
PASSED: [[SimpleTest]]: [MySQL] 58,682 pass(es).
[ View ]
new964 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,685 pass(es).
[ View ]

forget to add fail patch

StatusFileSize
new2.86 KB
PASSED: [[SimpleTest]]: [MySQL] 58,700 pass(es).
[ View ]
new1.91 KB
FAILED: [[SimpleTest]]: [MySQL] 58,810 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

messed patches, fail patch with test only

Still RTBC but now demonstrates failing HEAD.
Great work.

Status:Reviewed & tested by the community» Fixed

Committed 2d10571 and pushed to 8.x. Thanks!

Great to see this fixed, but it wasn't really a bug... This never worked with global $user either.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.