Files: 
CommentFileSizeAuthor
#13 interdiff.txt2.93 KBtim.plunkett
#13 routes-2102653-13.patch78.12 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,816 pass(es).
[ View ]
#11 interdiff.txt21.83 KBtim.plunkett
#11 routes-2102653-11.patch75.19 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,664 pass(es), 29 fail(s), and 0 exception(s).
[ View ]
#9 drupal8.system-module.2102653-9.patch56.99 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 58,387 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
#9 interdiff.txt3.39 KBdisasm
#8 routing-2102653-8.patch53.6 KBtim.plunkett
PASSED: [[SimpleTest]]: [MySQL] 58,806 pass(es).
[ View ]
#8 interdiff.txt3.41 KBtim.plunkett
#6 routing-2102653-6.patch52.78 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,311 pass(es), 29 fail(s), and 0 exception(s).
[ View ]
#6 interdiff.txt8.22 KBtim.plunkett
#4 routing-2102653-4.patch50.52 KBtim.plunkett
FAILED: [[SimpleTest]]: [MySQL] 58,718 pass(es), 38 fail(s), and 5 exception(s).
[ View ]
#2 drupal8.system-module.2102653-1.patch48.92 KBdisasm
FAILED: [[SimpleTest]]: [MySQL] 58,204 pass(es), 39 fail(s), and 5 exception(s).
[ View ]

Comments

#2091691: Convert test non-form page callbacks to routes and controllers has an insane amount of fixes, and also touches a lot of the same code. Might be worth starting from there or waiting a day or two

Status:Active» Needs review
StatusFileSize
new48.92 KB
FAILED: [[SimpleTest]]: [MySQL] 58,204 pass(es), 39 fail(s), and 5 exception(s).
[ View ]

first pass converting just form_test module (which has the bulk of the callbacks). Want to see if this is green before adding the others.

StatusFileSize
new50.52 KB
FAILED: [[SimpleTest]]: [MySQL] 58,718 pass(es), 38 fail(s), and 5 exception(s).
[ View ]

StatusFileSize
new8.22 KB
new52.78 KB
FAILED: [[SimpleTest]]: [MySQL] 58,311 pass(es), 29 fail(s), and 0 exception(s).
[ View ]

We don't want or need FileInclusionTest anymore, its obsolete (the only way to fix the tests would be to manually module_load_include(), which defeats the purpose).

The rest of the changes were mostly fixes to called form IDs or bad route paths.

StatusFileSize
new3.41 KB
new53.6 KB
PASSED: [[SimpleTest]]: [MySQL] 58,806 pass(es).
[ View ]

Okay this should be green, carry on with the rest of the conversions.

Assigned:disasm» Unassigned
StatusFileSize
new3.39 KB
new56.99 KB
FAILED: [[SimpleTest]]: [MySQL] 58,387 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

language_elements_test module converted. Unassigning since timplunkett said he might have some time to work on this.

StatusFileSize
new75.19 KB
FAILED: [[SimpleTest]]: [MySQL] 58,664 pass(es), 29 fail(s), and 0 exception(s).
[ View ]
new21.83 KB

Here's the rest. We'll see if it passes...

StatusFileSize
new78.12 KB
PASSED: [[SimpleTest]]: [MySQL] 58,816 pass(es).
[ View ]
new2.93 KB

Just another case of a test directly accessing a MENU_DEFAULT_LOCAL_TASK

  1. +++ b/core/modules/file/tests/file_module_test/file_module_test.module
    @@ -10,27 +10,13 @@
    -  $items['file/test'] = array(
    -    'title' => 'Managed file test',
    -    'page callback' => 'drupal_get_form',
    -    'page arguments' => array('file_module_test_form'),
    -    'access arguments' => array('access content'),
    -  );

    Wait, this isn't a menu callback so why is this removed entirely?

  2. +++ b/core/modules/system/lib/Drupal/system/Tests/Batch/ProcessingTest.php
    @@ -46,34 +46,34 @@ function testBatchNoForm() {
    -    $this->drupalPostForm('batch-test/simple', $edit, 'Submit');
    +    $this->drupalPostForm('batch-test', $edit, 'Submit');
    ...
    -    $this->drupalPostForm('batch-test/simple', $edit, 'Submit');
    +    $this->drupalPostForm('batch-test', $edit, 'Submit');
    +++ b/core/modules/system/tests/modules/batch_test/batch_test.module
    @@ -13,9 +13,7 @@ function batch_test_menu() {
       $items['batch-test/simple'] = array(
    +++ b/core/modules/system/tests/modules/batch_test/batch_test.routing.yml
    @@ -31,6 +31,30 @@ batch_test.no_form:
    +batch_test.test_form:
    +  path: '/batch-test'

    I try to figure out why this change of the path was needed, as this adds additional hunks.

  3. +++ b/core/modules/system/tests/modules/form_test/form_test.module
    @@ -2101,8 +1846,10 @@ function form_test_programmatic_form_submit($form, &$form_state) {
    +function form_test_clicked_button($form, &$form_state, $first, $second, $third) {
    @@ -2119,7 +1866,7 @@ function form_test_clicked_button($form, &$form_state) {
    -  $args = array_slice(arg(), 2);
    +  $args = array($first, $second, $third);

    I like this tiny change!

1) It's a test, and the menu link is never used. I think when it was written it should have been type => MENU_CALLBACK, the test author just skipped it

2) batch-test/simple is the MENU_DEFAULT_LOCAL_TASK. It's like how node/{node}/view is no longer valid, or admin/structure/types/manage/{node_type}/edit.

3) Yes! Tiny wins.

Status:Needs review» Reviewed & tested by the community

Thank you for the explanation!

Status:Reviewed & tested by the community» Fixed

I only saw two things that stuck out to me in my review:

+++ /dev/null
@@ -1,47 +0,0 @@
-class FileInclusionTest extends WebTestBase {

Where did this test go?

Basically, we don't need it anymore because we no longer support loading forms from separate .inc files in favour of class loading.

+++ b/core/modules/system/tests/modules/form_test/form_test.module
@@ -2101,8 +1846,10 @@ function form_test_programmatic_form_submit($form, &$form_state) {
-function form_test_clicked_button($form, &$form_state) {
+function form_test_clicked_button($form, &$form_state, $first, $second, $third) {

I actually find this pretty bizarre, but it does indeed clean up the code below. Since it's a deprecated function anyway, not really worth bothering about atm.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.