When cache for anonymous users is active, the form is not refreshed after an answer is added, update or delete. This can lead to multiple inputs and misundestandings.

Patch is coming.

CommentFileSizeAuthor
#13 makemeeting-invalidate_page_cache_on_crud_answer-2104033-13.patch4.25 KBDuaelFr
#13 interdiff.txt3.24 KBDuaelFr
#12 makemeeting-invalidate_page_cache_on_crud_answer-2104033-12.patch1.37 KBDuaelFr
#8 2104033-8-clear_anonymous_cache.patch1.64 KBSebCorbin
#7 makemeeting-invalidate_page_cache_on_crud_answer-2104033-7.patch1.76 KBDuaelFr
#7 interdiff.txt2.38 KBDuaelFr
#6 makemeeting-invalidate_page_cache_on_crud_answer-2104033-6.patch1.3 KBDuaelFr
#6 interdiff.txt587 bytesDuaelFr
#5 makemeeting-invalidate_page_cache_on_crud_answer-2104033-5.patch1.28 KBDuaelFr
#5 interdiff.txt1.66 KBDuaelFr
#3 makemeeting-invalidate_page_cache_on_crud_answer-2104033-3.patch1.19 KBDuaelFr
#1 makemeeting-invalidate_page_cache_on_crud_answer-2104033-1.patch1.18 KBDuaelFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Assigned: DuaelFr » Unassigned
Status: Active » Needs review
FileSize
makemeeting-invalidate_page_cache_on_crud_answer-2104033-1.patch1.18 KB

Please test it carefully because I coded it without a running instance ;)

This patch is part of the #1day1patch initiative.

Pomliane’s picture

Pomliane CreditAttribution: Pomliane commented

Thanks DuaelFR for the patch!
Unfortunately, it does not seem to work here.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
FileSize
makemeeting-invalidate_page_cache_on_crud_answer-2104033-3.patch1.19 KB

Here is the new working one...
Fucking trailing slashes... :D

Pomliane’s picture

Pomliane CreditAttribution: Pomliane commented
Status: Needs review » Reviewed & tested by the community

Works here too! :)

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff.txt1.66 KB
makemeeting-invalidate_page_cache_on_crud_answer-2104033-5.patch1.28 KB

Minor performances improvement.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
FileSize
interdiff.txt587 bytes
makemeeting-invalidate_page_cache_on_crud_answer-2104033-6.patch1.3 KB

Hmm... This is better...
The previous patch never existed.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Title: Invalidate page cache when add/edit/delet'ing an answer » Invalidate core page cache and contrib Entity Cache when add/edit/delet'ing an answer
FileSize
interdiff.txt2.38 KB
makemeeting-invalidate_page_cache_on_crud_answer-2104033-7.patch1.76 KB

Let's improve it again !
This now includes Entity Cache support.

Enjoy !

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
FileSize
2104033-8-clear_anonymous_cache.patch1.64 KB

Rerolled and replaced '/' by the correct function (base_path) so that it works in subdirectories.

I wonder if we should simply use cache_clear_all() as it is actually done in node_save()...

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Status: Needs review » Needs work

There is no base_path() function in your patch but it is a good idea !

I think it would be a bad idea to use cache_clear_all() here because of performances issues on websites that could use this module intensely. Imagine Doodle clearing all cache each time an answer is posted, edited or deleted... Moreover, cache_clear_all() only clean page and block cache, not Entity Cache.

SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
Status: Needs work » Fixed

Committed as is (with base_path) and credited, thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Issue summary: View changes
Status: Closed (fixed) » Needs review
FileSize
makemeeting-invalidate_page_cache_on_crud_answer-2104033-12.patch1.37 KB

Reoppening to better handle the entity cache and fix an issue if the page showing the form is using an alias.

This patch has been made on the current dev version obviously.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
FileSize
interdiff.txt3.24 KB
makemeeting-invalidate_page_cache_on_crud_answer-2104033-13.patch4.25 KB

Another big patch to also clear the cache of entities that would reference the entity having the makemeeting field using the Entity Reference module.

Review carefully.

Pomliane’s picture

Pomliane CreditAttribution: Pomliane commented

Works well here, many thanks DuaelFr!

  • SebCorbin committed 37a86d7 on 7.x-2.x 
    Follow-up #Issue #2104033 by DuaelFr, SebCorbin: Invalidate core page...
SebCorbin’s picture

SebCorbin CreditAttribution: SebCorbin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.