This is a general issue for coder cleanup. Using the coder module to cleanup makes submitting patches easier and self documenting easier as noted at: https://drupal.org/node/1115704#comment-7929993

If anyone wants to commit coder cleanup, submit one patch for each module in this thread. Coder cleanup is as simple as installing the coder module and fixing spacing, code conventions, and self documentation comments. There are some coder errors related to unsafe text that cannot be fixed in the ldap module because stripping, escaping, or otherwise cleaning the data presents additional issues.

Patches should include minor issues and cover a whole module; its not worth bothering with any coder related patches that are smaller.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

geerlingguy’s picture

Status: Active » Needs review
FileSize
15.32 KB

Attached patch cleans up the ldap_sso module.

johnbarclay’s picture

Status: Needs review » Fixed

Thanks. This is committed.

geerlingguy’s picture

Status: Fixed » Needs work

Back to CNW so I can take on another module :)

grahl’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)

D8 refactoring takes care of this for the most part.