This is a general issue for coder cleanup. Using the coder module to cleanup makes submitting patches easier and self documenting easier as noted at: https://drupal.org/node/1115704#comment-7929993
If anyone wants to commit coder cleanup, submit one patch for each module in this thread. Coder cleanup is as simple as installing the coder module and fixing spacing, code conventions, and self documentation comments. There are some coder errors related to unsafe text that cannot be fixed in the ldap module because stripping, escaping, or otherwise cleaning the data presents additional issues.
Patches should include minor issues and cover a whole module; its not worth bothering with any coder related patches that are smaller.
Comment | File | Size | Author |
---|---|---|---|
#1 | ldap.coder-cleanup-sso.2104117-1.patch | 15.32 KB | geerlingguy |
Comments
Comment #1
geerlingguy CreditAttribution: geerlingguy commentedAttached patch cleans up the ldap_sso module.
Comment #2
johnbarclay CreditAttribution: johnbarclay commentedThanks. This is committed.
Comment #3
geerlingguy CreditAttribution: geerlingguy commentedBack to CNW so I can take on another module :)
Comment #4
grahlD8 refactoring takes care of this for the most part.