Found a redundant closing tag in theme_test.template_test.tpl.php and this patch fixes it.

CommentFileSizeAuthor
#3 redundant1_1.patch666 bytescosmicdreams
redundant1.patch670 bytescosmicdreams
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

There's an extra blank line in the @file block. Also, I think we normally put a blank line before the /** for the @file? Thanks!

cosmicdreams’s picture

cosmicdreams CreditAttribution: cosmicdreams commented
Status: Needs work » Needs review
FileSize
redundant1_1.patch666 bytes

Here are those fixes

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Sorry, didn't notice this before:

+ * @file
+ * Print required message for tests

Line should end in ., and our standards for @file say if it starts with a verb, it should be "Prints".
https://drupal.org/node/1354#file

Thanks!

LinL’s picture

LinL CreditAttribution: LinL commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)

Can be closed, PHPTemplate is gone! #2574717: Remove PHPTemplate, and add test coverage for multiple theme engine support