Problem/Motivation

Configuration translation module just starts to use the new local task derivatives, and some core paths don't use named local tasks proper or name their local tasks improperly. The attached patch aims to fix these for the use cases where config translation fails to match up tabs with the core tabs due to the inconsistencies.

1. The maintenance tab in system tabs was improperly named, it should be $route_name . '_tab' for the default tab.
2. The user account settings tab is not defined with the local tasks .yml
3. The config test module is not converted to local tasks.yml and includes generally useless items in hook_menu anyway.

Proposed resolution

Fix those in the scope to let config translation properly work with these tabs in contrib with the *new way* [TM]. So far while these are not properly fixed, config translation needs to use the old way. #sadpanda

Remaining tasks

Review, commit.

User interface changes

None.

API changes

None.

#2095269: Remove add_edit_tab, core should have default tabs

Files: 
CommentFileSizeAuthor
#4 fix-tabs-for-config-translation-core-4.patch2.73 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 58,408 pass(es).
[ View ]
#4 interdiff.txt519 bytesGábor Hojtsy
#3 fix-tabs-for-config-translation-core-3.patch2.76 KBGábor Hojtsy
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
fix-tabs-for-config-translation-core.patch4.55 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 58,763 pass(es).
[ View ]

Comments

Title:Fix several small inconsistencies + lack of tab conversionFix several small tab inconsistencies + lack of tab conversion

Issue tags:+blocker

Marking as blocker for #2095269: Remove add_edit_tab, core should have default tabs and consequently config_translation module in core.

StatusFileSize
new2.76 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

@vijaycs85 pointed out the moving of title from hook_menu to route yml may be an issue with some edge case currently. Since those are not needed to fulfill this patch I removed them. I also forgot to add the config test local task yaml in the above patch, so now included. This is the absolute minimal set of changes needed to resolve this, get tabs up to speed on these places (and it will make config_translation pass green again on testbot :D).

StatusFileSize
new519 bytes
new2.73 KB
PASSED: [[SimpleTest]]: [MySQL] 58,408 pass(es).
[ View ]

Aand make sure to include newline at end of file :D

Title:Fix several small tab inconsistencies + lack of tab conversionFix small tab inconsistencies + lack of tab conversion

Status:Needs review» Reviewed & tested by the community

Thanks @Gábor Hojtsy. Changes looks good to me. RTBC, if testbot is happy.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Local Tasks, -D8MI, -language-config, -blocker

The last submitted patch, fix-tabs-for-config-translation-core-4.patch, failed testing.

Status:Needs work» Needs review
Issue tags:+Local Tasks, +D8MI, +language-config, +blocker

Status:Needs review» Reviewed & tested by the community

As per above. Test issue was a bot fluke.

Makes total sense. Just to make this clear to committers: This patch fixes the currently failing tests in config_translation, because the local tabs due not appear currently where they should. Therefore this stops all progress in config_translation due to the branch failing. It would be awesome if this could go in soon.

Title:Fix small tab inconsistencies + lack of tab conversionQuick fix: small tab inconsistencies + lack of tab conversion
Issue tags:+Quick fix

Adding one more tag to help committers find it :)

Status:Reviewed & tested by the community» Fixed

This looks good to me. It'll conflict with the patch floating out there somewhere that attempts to convert all local tasks at once, but I don't see it in the RTBC list atm so I think this is fine.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.