I wanted to propose this small patch to rename all cache prefixes in the same way. This discussion was started in the following ticketSearchPluginManager plugin definitions aren't cached and I thought it was nice to have something consistent between them.

Any suggestion is more than welcome on either include other files I missed or leave some of them I patched alone for a specific reason currently unknown to me.

Files: 
CommentFileSizeAuthor
#7 plugins_cache_prefixes_name_convention_consistency-3.patch13.13 KBBladedu
PASSED: [[SimpleTest]]: [MySQL] 58,963 pass(es).
[ View ]
#7 interdiff.txt1.3 KBBladedu
#3 plugins_cache_prefixes_name_convention_consistency-2.patch13.1 KBBladedu
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch plugins_cache_prefixes_name_convention_consistency-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 interdiff.txt599 bytesBladedu
plugins_cache_prefixes_name_convention_consistency.patch12.4 KBBladedu
PASSED: [[SimpleTest]]: [MySQL] 58,707 pass(es).
[ View ]

Comments

I do like the _plugins suffix as it makes it clear that this is about the plugin information.

Is there a reason why this hunk in LocalTaskManager was not changed?

$this->setCacheBackend($cache, $language_manager, 'local_task', array('local_task' => TRUE));

as well as this line in ConfigMapperManager:

    $this->setCacheBackend($cache_backend, $language_manager, 'config_translation_info');

You could argue that the local task manager stores more than just the local task plugin information as it also stores information by route.

Status:Needs review» Needs work

Good remark and I agree with you that localManager should also be included. I will reroll the previous patch including the missing plugin managers.

Thanks for the review :)

Status:Needs work» Needs review
StatusFileSize
new599 bytes
new13.1 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch plugins_cache_prefixes_name_convention_consistency-2.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Included LocalTaskManager to the list of renamed cache prefixes.
For the config_translation module, I'll propose a patch to its project issue list.

Status:Needs review» Reviewed & tested by the community

Great, thank you!

Status:Reviewed & tested by the community» Needs work

The last submitted patch, plugins_cache_prefixes_name_convention_consistency-2.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new1.3 KB
new13.13 KB
PASSED: [[SimpleTest]]: [MySQL] 58,963 pass(es).
[ View ]

Re-rolled patch. ImageToolkitManager was moved from system module to ImageToolkit module.

Status:Needs review» Reviewed & tested by the community

Excellent, thanks! Back to RTBC.

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.