API page: https://api.drupal.org/api/drupal/core%21modules%21block%21lib%21Drupal%...

Enter a descriptive title (above) relating to class RouteSubscriber, then describe the problem you have found:

The class documentation for this class just says "Listens to the dynamic route events.". This doesn't really tell me what the class does. It would be better if it (with the corrected verb tense!) used the documentation from its method, which at least tells me it is providing dynamic routes for the block module, which is what the class actually does.

Files: 
CommentFileSizeAuthor
#3 blockRouteSubscriber-2105807-3.patch850 bytesStephaneQ
PASSED: [[SimpleTest]]: [MySQL] 58,877 pass(es).
[ View ]
#1 reroll-test.patch2.78 KBmikegoodwin
FAILED: [[SimpleTest]]: [MySQL] 58,954 pass(es), 10 fail(s), and 12 exception(s).
[ View ]

Comments

StatusFileSize
new2.78 KB
FAILED: [[SimpleTest]]: [MySQL] 58,954 pass(es), 10 fail(s), and 12 exception(s).
[ View ]

I'm attempting to re-roll the latest patch against the latest D8.

I think the patch in #1 is for a different issue?

Status:Active» Needs review
StatusFileSize
new850 bytes
PASSED: [[SimpleTest]]: [MySQL] 58,877 pass(es).
[ View ]

Here is another patch.

Status:Needs review» Reviewed & tested by the community

Thanks! Looks good to me.

I'm sorry about that...a stupid mistake on my part...trying to learn core contribution

Status:Reviewed & tested by the community» Fixed

Thanks again! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.