Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
custom_block.type.basic.yml
entity.view_mode.custom_block.full.yml
block.block.stark.test_block.yml
views.view.test_view_block.yml
views.view.test_view_block2.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#14 interdiff.txt441 bytesfoxtrotcharlie
#14 2105915-block-test-config-14.patch3.1 KBfoxtrotcharlie
PASSED: [[SimpleTest]]: [MySQL] 59,345 pass(es).
[ View ]
#12 2105915-block-test-config-12.patch3.53 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,597 pass(es).
[ View ]
#5 2105915-diff-3-5.txt2.47 KBvijaycs85
#5 2105915-block-test-config-5.patch3.28 KBvijaycs85
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2105915-block-test-config-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#3 2105915-block-yml-type-casting-3.patch3.24 KBfoxtrotcharlie
PASSED: [[SimpleTest]]: [MySQL] 59,927 pass(es).
[ View ]
#1 2105915-block-yml-type-casting-1.patch4.2 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 58,792 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new4.2 KB
PASSED: [[SimpleTest]]: [MySQL] 58,792 pass(es).
[ View ]

Initial patch...

Issue summary:View changes
Status:Needs review» Needs work
Issue tags:+Needs reroll

Needs a reroll.

Assigned:Unassigned» foxtrotcharlie
Status:Needs work» Needs review
Issue tags:-Needs reroll
StatusFileSize
new3.24 KB
PASSED: [[SimpleTest]]: [MySQL] 59,927 pass(es).
[ View ]

My first reroll - hope it's right...

I just noticed that in block_test_theme.info.yml and entity.view_mode.custom_block.full.yml the booleans true and false are lowercase and not uppercase. Should they be changed to uppercase? There is also a value of '-1' (in the single quotes) in block.block.test_block.yml and I wonder if it the quotes should be removed?

StatusFileSize
new3.28 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2105915-block-test-config-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new2.47 KB

Fixing the conversions missed in #3

Is there any reason why we're not fixing up "block.routing.yml" here as well? eg the _access_theme properties.

@benjy the meta is more about the config, routing or info aren't config.

Status:Needs review» Reviewed & tested by the community

OK sounds good.

5: 2105915-block-test-config-5.patch queued for re-testing.

5: 2105915-block-test-config-5.patch queued for re-testing.

The last submitted patch, 5: 2105915-block-test-config-5.patch, failed testing.

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new3.53 KB
PASSED: [[SimpleTest]]: [MySQL] 59,597 pass(es).
[ View ]

Re-rolling...

+++ b/core/modules/block/tests/modules/block_test/block_test.info.yml
@@ -4,4 +4,4 @@ description: 'Provides test blocks.'
+hidden: TRUE

Why is this uppercase now?

StatusFileSize
new3.1 KB
PASSED: [[SimpleTest]]: [MySQL] 59,345 pass(es).
[ View ]
new441 bytes

I've changed the uppercase TRUE back to lowercase true. According to this comment by chx and this info in the Symfony documentation, Symfony uses lowercase for booleans.

Sorry for my mistake... +1 to RTBC.

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.