Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

1. There is no 'status' and 'langcode' elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has type casting.

Proposed resolution

Fix them in the list

Remaining tasks

Fix and issue patch.

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#5 contact_config-2105927-5.patch5.35 KBa_thakur
PASSED: [[SimpleTest]]: [MySQL] 59,067 pass(es).
[ View ]
#3 contact_config-2105927-3.patch5.11 KBa_thakur
PASSED: [[SimpleTest]]: [MySQL] 59,042 pass(es).
[ View ]

Comments

Status:Active» Reviewed & tested by the community

Went through the following files and could not find any such occurrence of integers, Booleans, octal numbers in config object files as strings.

  • contact.category.feedback.yml
  • contact.category.personal.yml
  • contact.settings.yml
  • views.view.test_contact_link.yml

Changing to reviewed & tested by community

Title:Make sure all YML files in Contact module has no type-casting to string.Complete config of Contact module
Status:Reviewed & tested by the community» Needs work

yeah, we don't have type casting, but we do miss few element on default config. Updating issue summary/title to reflect the new scope of this issue.

1. There is no status and language elements in contact.category.*.yml
2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
3. views.view.test_contact_link.yml has lots of integer in quotes

Status:Needs work» Needs review
StatusFileSize
new5.11 KB
PASSED: [[SimpleTest]]: [MySQL] 59,042 pass(es).
[ View ]

Fixed the following, please review

  1. Added status and language elements in contact.category.*.yml
  2. contact.settings.user_default_enabled become 1 in active dir whereas module has true
  3. Removed quotes for integers in views.view.test_contact_link.yml.

Issue summary:View changes

Updated issue summary.

Issue summary:View changes
Status:Needs review» Needs work
  1. +++ b/core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml
    @@ -2,13 +2,13 @@ base_field: uid
    +status: 1

    should be true.

  2. +++ b/core/modules/contact/tests/modules/contact_test_views/test_views/views.view.test_contact_link.yml
    @@ -21,42 +21,42 @@ display:
    +          slave: 0
    ...
    ...
    ...

    all boolean values should be true/false.

Status:Needs work» Needs review
StatusFileSize
new5.35 KB
PASSED: [[SimpleTest]]: [MySQL] 59,067 pass(es).
[ View ]

Changed all boolean to true/false.

Status:Needs review» Reviewed & tested by the community

Looks good to me!

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.