Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
views.view.files.yml
views.view.file_extension_view.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#3 2105957-file-config-cleanup-3.patch3.99 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,418 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new7.9 KB
PASSED: [[SimpleTest]]: [MySQL] 59,841 pass(es).
[ View ]

Initial patch

Status:Needs review» Needs work
  1. +++ b/core/modules/file/config/views.view.files.yml
    @@ -30,11 +30,11 @@ display:
    -          reset_button_label: Reset
    +          reset_button_label: 'Reset'
    ...
    -          sort_asc_label: Asc
    -          sort_desc_label: Desc
    +          sort_asc_label: 'Asc'
    +          sort_desc_label: 'Desc'
    @@ -174,11 +174,11 @@ display:
    -          label: Name
    +          label: 'Name'
    @@ -248,7 +248,7 @@ display:
    -          label: Size
    +          label: 'Size'
    @@ -298,7 +298,7 @@ display:
    -          label: Status
    +          label: 'Status'
    @@ -460,11 +460,11 @@ display:
    -            label: Filename
    +            label: 'Filename'
    @@ -522,25 +522,25 @@ display:
    -            label: Status
    +            label: 'Status'
    @@ -652,7 +652,7 @@ display:
    +          label: 'Entity'
    @@ -947,7 +947,7 @@ display:
    -label: Files
    +label: 'Files'

    Don't think we need to make these changes as part of this issue.

  2. +++ b/core/modules/file/tests/modules/file_test_views/test_views/views.view.file_extension_view.yml
    @@ -1,15 +1,15 @@
    -core: '8'
    +core: 8.x

    we don't really need to change any in this. not part of this issue.

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new3.99 KB
PASSED: [[SimpleTest]]: [MySQL] 59,418 pass(es).
[ View ]

updates...

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.

Status:Needs review» Closed (duplicate)