Follow-up from #1653026: [META] Use properly typed values in module configuration.

Problem/Motivation

All integers, Booleans, and even octal numbers in config object files are converted to strings.

Proposed resolution

#1653026: [META] Use properly typed values in module configuration has fixed core, so no need to convert all data types to string anymore.

Remaining tasks

Fix and issue patch for below config files:
entity.view_mode.node.full.yml
entity.view_mode.node.rss.yml
entity.view_mode.node.teaser.yml
node.settings.yml
system.action.node_delete_action.yml
system.action.node_make_sticky_action.yml
system.action.node_make_unsticky_action.yml
system.action.node_promote_action.yml
system.action.node_publish_action.yml
system.action.node_save_action.yml
system.action.node_unpromote_action.yml
system.action.node_unpublish_action.yml
views.view.content.yml
views.view.frontpage.yml
node_access_test_language.info.yml (tab missing in dependencies list)
node.type.default.yml
node.type.import.yml
views.view.test_contextual_links.yml
views.view.test_field_type.yml
views.view.test_filter_node_uid_revision.yml
views.view.test_node_bulk_form.yml
views.view.test_node_revision_nid.yml
views.view.test_node_revision_vid.yml
views.view.test_node_row_plugin.yml
views.view.test_node_view.yml
views.view.test_status_extra.yml

User interface changes

NO

API changes

NO

Parent: #1653026: [META] Use properly typed values in module configuration

Files: 
CommentFileSizeAuthor
#6 2105977-node-config-cleanup-6.patch11.78 KBvijaycs85
PASSED: [[SimpleTest]]: [MySQL] 59,403 pass(es).
[ View ]
#3 2105977-2-node-yaml-variable-type.patch93.96 KBdanilenko_dn
PASSED: [[SimpleTest]]: [MySQL] 59,756 pass(es).
[ View ]
#1 2105977-1-node-yaml-variable-type.patch44.98 KBdanilenko_dn
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2105977-1-node-yaml-variable-type.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Comments

Assigned:Unassigned» danilenko_dn
Status:Active» Needs review
StatusFileSize
new44.98 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2105977-1-node-yaml-variable-type.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Status:Needs review» Needs work

The last submitted patch, 2105977-1-node-yaml-variable-type.patch, failed testing.

Status:Needs work» Needs review
StatusFileSize
new93.96 KB
PASSED: [[SimpleTest]]: [MySQL] 59,756 pass(es).
[ View ]

fixed missing tab in
\node\tests\modules\node_access_test_language\node_access_test_language.info.yml:7

Status:Needs review» Needs work

+++ b/core/modules/node/config/system.action.node_save_action.ymlundefined
@@ -1,7 +1,7 @@
-status: '1'
+status: 1

Is this really supposed to be the integer 1 or a boolean value? The key of 'status' implies the latter to me. I saw this a few other places as well.

+++ b/core/modules/node/config/views.view.content.ymlundefined
@@ -56,80 +56,80 @@ display:
-              empty_column: false

In other conversion I've seen we use lowercase false instead of uppercase, we should figure out what we want to standardize on.

Also there are some weird characters at the top of this patch which is causing it to fail when I try to apply it with git. When I try to less it, it thinks that it is a binary file. Could you reroll?

Issue summary:View changes
Status:Needs work» Needs review
StatusFileSize
new11.78 KB
PASSED: [[SimpleTest]]: [MySQL] 59,403 pass(es).
[ View ]

Reroll...

The patch on this issue has been updated as part of #2167623: Add test for all default configuration to ensure schema exists and is correct. As this issue doesn't have any test to confirm/validate the schema, making this change and closing this issue as duplicate of #2167623: Add test for all default configuration to ensure schema exists and is correct. The contributors of this issue (in commit message) is copied to #2167623: Add test for all default configuration to ensure schema exists and is correct.

Status:Needs review» Closed (duplicate)