Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Split from #2102521: Finish converting menu.module to CMI.
Child of #1775842: [meta] Convert all variables to state and/or config systems
core/modules/menu/menu.module includes the following calls to the variable system, which will not be available in Drupal 8.
217 $active_menus = variable_get('menu_default_active_menus', array_keys(menu_get_menus()));
221 variable_set('menu_default_active_menus', $active_menus);
This variable has been partially migrated to system.menu.active_menus_default
Comment | File | Size | Author |
---|---|---|---|
#4 | 2106097-active-menus-default-4.patch | 1.53 KB | ianthomas_uk |
#4 | 2106097-1-4-interdiff.txt | 1.18 KB | ianthomas_uk |
#1 | 2106097-active-menus-default-1.patch | 1.06 KB | ianthomas_uk |
Comments
Comment #1
ianthomas_ukComment #2
vijaycs85Looks good to me. Except a minor coding standard bug.
Minor: Comment exceeds 80 chars limit and missing period at the end.
btw, foreach-- :), so ianmthomasuk++
Comment #3
vijaycs85Also noted that the system_update_8033 trying to update the wrong variable name (i.e. 'active_menus_default'). Can you update system_update_8033 as well please? It should be:
Comment #4
ianthomas_ukNew patch addressing #2 and #3
Comment #5
vijaycs85Thanks @ianmthomasuk.
+1 from my side to RTBC.
Comment #6
catchComment #7
BerdirWrong component?
Comment #8
catchCommitted/pushed to 8.x, thanks!