Cannot upload files when plupload_temporary_uri is not a PHP stream

Cannot reproduce this. You probably have some other problems.

The problem is that if variable plupload_temporary_uri has a path instead of a file stream, file_prepare_directory() gets rid of the trailing slash, so when later on the code does fopen(), it fails since there is no slash between $temp_directory and $file_name.

This code in includes/file.inc converts /tmp/ into /tmp. Note that $directory is passed by reference.

function file_prepare_directory(&$directory, $options = FILE_MODIFY_PERMISSIONS) {
  if (!file_stream_wrapper_valid_scheme(file_uri_scheme($directory))) {
    // Only trim if we're not dealing with a stream.
    $directory = rtrim($directory, '/\\');
  }

Attached is a patch that I tested with both a path and a stream wrapper.

@vishy_singhal I'm not sure that's the root cause of this issue and certainly not worth modifying database.inc for.

@slashrsm I've been able to repro this on a HA environment using the plupload_temporary_uri to point to an alternate path for plupload files.

File /path/to/temp/filesp187kdg91hfjsik8n941a7b111spq1.tmp could not be copied because it does not exist.

This points to a particular issue within plupload where the slash is removed from the temporary path as juampy says in #2

Here is an updated version where I am fixing another part of the logic which causes the same issue. I will post testing instructions in the next comment.

1. +++ b/plupload.module
   @@ -190,7 +190,7 @@ function plupload_element_value(&$element, $input = FALSE, $form_state = NULL) {
   +        $files[$i]['tmppath'] = variable_get('plupload_temporary_uri', 'temporary://') . '/' . $value;
   

   This change makes sure that even though plupload_temporary_uri has a values like /tmp (note there is no trailing slash), we do add it in order to build a full path to an uploaded file such as /tmp/foo.jpg.

2. +++ b/plupload.module
   @@ -378,6 +378,13 @@ function plupload_handle_uploads() {
   +    $temp_directory .= '/';
   

   This change addresses the fact that file_prepare_directory() removes the trailing slash from a path like /tmp/.

Oops, used the wrong field to change the title.

Yes @vishy_singhal.

@vishy_singhal, yes, I used the patch at #5.

I am sorry @vishy_singhal, I cann't test this issue more. Already had a problem and gave solution to it.

This issue still exists in the latest dev and stable releases. I applied the patch from @juampynr from comment #5 and this fixes the issue. Can this patch be applied to the dev release?

I'm experiencing this issue too and specifically getting the error:

The specified file temporary://jc2m8j3r92h3r98f23rsad.tmp could not be copied, because no file by that name exists. Please check that you supplied the correct filename.

What's weird is that when I try to upload 1 or 2 images, it passes but when I upload like 7 images about 800KB plus I get the said error.

I'm also using Pantheon as my host and the test/staging site is fine while production has the error. Also I checked my temporary directory value and it's formed as /srv/bindings/some-hash-here/tmp so there's not trailing slash.

Any ideas on why this inconsistency is happening?

Patch in #5 by juampynr doesn't work for a plupload_temporary_uri in the form of a PHP stream without a trailing slash like this:

temporary://plupload-temp

While reviewing the patch, I found that current module is not really working as expected in this situation: when plupload_temporary_uri is a PHP stream without a trailing slash.

It works, but the used temp file is not stored in the correct directory: directory and file name are concatenated resulting in things like:

temporary://plupload-tempo_1bc3ntv2s1pknqb316bu15lp14i6a.tmp

This second problem happens exactly in the same piece of code we are talking about so I think they are too related to solve them separately.

Attached patch solves the problem in a consistent way for all kind of value for plupload_temporary_uri:

$conf['plupload_temporary_uri'] = 'temporary://';
$conf['plupload_temporary_uri'] = 'temporary://plupload-temp';
$conf['plupload_temporary_uri'] = 'temporary://plupload-temp/';
$conf['plupload_temporary_uri'] = 'sites/default/files/tmp/plupload-temp';
$conf['plupload_temporary_uri'] = 'sites/default/files/tmp/plupload-temp/';

It could have been solved in the opposite way maybe with a bit less of code, but looking at file_stream_wrapper_uri_normalize and file_prepare_directory it seems uris not having trailing slashes are more aligned with core than having them.

And this is the patch for 8.x-2.x branch, which has exactly the same problem.

Updated issue summary because it doesn't reflect the problem we are currently solving.

Confirmed that the patch in #17 works great. I can't comment about D8 though, otherwise I'd mark this RTBC.

Hello,
For me on D8, I still have links on temporary files, even with patch # 18
I do not know what to try to make the plupload module work :-(

#17 works great.