Support for no-javascript fallback

First, I think the module could implement the standard ajax/nojs convention in the url path, e.g. /ajax_comments/nojs/reply/*/* And the module could handle the nojs path by redirecting to the standard comment module url, e.g. /comment/reply/*/*

For me this seems to be the way to go. I took over maintainership of the module and this was on my todo list. It would be great if you could provide a patch. I would review and commit it.

wow that was quick! I'm sorry but your patch doesn't apply anymore. :/ I pushed lot's of changes this morning and i think you downloaded the current development release or not? Please fetch from git: Drupal infrastructure only builds releases once or twice a day...

https://drupal.org/project/ajax_comments/git-instructions

I re-rolled this patch against the current dev branch to address any differences as well as the removing the delivery callback from #4 for the comment edit menu callback (probably snuck in during the merge resolutions).

I couldn't find where the now 4th and 5th args for the menu item for reply are set. They don't seem to be set anywhere in the .module code. I had consistent issues with the menu router failing as a result - since they have defaults of (NULL and 'node') and they work as optional items for the menu item and there were no failures I pulled them per the original patch.

Thanks a lot! This looks good! Could somebody test this please then i will commit it asap....

deleted: wrong queue.

after looking at the other patch I found that this line in ajax_comments/views might have to be altered also:

views/ajax_comments_handler_field_ajax_add_comment.inc:50:      $path = 'ajax_comments/reply/' . $node->nid."/NULL/views";

Edit 6/26/14:
the line should be:

views/ajax_comments_handler_field_ajax_add_comment.inc:50:      $path = 'ajax_comments/nojs/reply/' . $node->nid;

SocialNicheGuru - hmm, it looks like that it is already pointed to the correct menu router - ln 66 of ajax_comments.module, am I missing something? Happy to address whatever helps the nojs fallback here, I think I just am not following.

In other news, muschpusch - we've been running this without issue, but it would be good to have another eye on it.

@theBruce, it was suggested that adding to your solution might fix this issue: https://drupal.org/node/2266673

@thebruce it seems like the views plugin is still referencing the old handler. Could you please add that to the patch? Then i'm happy to commit it and create a new release

The fix gets the comment form to show up in a view
but I get the following error with linkit which is used with wysiwyg as part of panopoly distribution:

TypeError: Drupal.linkit is undefined
Drupal.linkit.dialog = Drupal.linkit.dialog || {};

/modules/contrib/linkit/js/linkit.dialog.js?v=7.2&_=1404796095185

also none of the wysiwyg editor paths are included so I get a 404 error for every plugin to the wysiwyg editor.

this no longer applies to beta1

i think we still need this

Re-rolled patch against last dev version.

You also replace same code in dev version.
For example $commands[] = ajax_command_prepend('.comment-wrapper-' . $pid . ' + .indented', $form) by $commands[] = ajax_command_before('.comment-wrapper-nid-' . $node->nid . '> .ajax-comment-wrapper:first', $form).
Why you did this?

I see a easy solution - use own javascript code for binding Ajax behaviors.
I'm working on this

wow, this solution are described in this issue as second way =)
Implemented and committed to latest dev. Important: clear cache after upgrade (menu links are changed to drupal core comment module style)

committed to 7.x-1.2