Updated: Comment #0

Problem/Motivation

Vertical Tabs are intentionally disabled when viewed in a narrow viewport. Which means that any code that assumes it can call tabHide() or tabShow() will break.

This is the case for filter.admin.js. It doesn't break, but it also stops showing/hiding the <details> (which are converted into Vertical Tabs when the screen is sufficiently wide) that contains a filter's settings when the corresponding filter is enabled/disabled.

Proposed resolution

Just show/hide the <details> element containing filter settings instead when Vertical Tabs aren't enabled.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Discovered thanks to #2102019-4: Vertical tabs looks broken on small screens.

Files: 
CommentFileSizeAuthor
#1 filter_settings_narrow-2108955-1.patch2.29 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 58,527 pass(es).
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new2.29 KB
PASSED: [[SimpleTest]]: [MySQL] 58,527 pass(es).
[ View ]

Issue tags:+JavaScript

.

Status:Needs review» Needs work

This should mess with the open attribute instead of show/hide from jQuery

Status:Needs work» Needs review

Huh? It already was using .tabShow() before. I'm merely fixing it. If using the open attribute is the better solution, that's fine, but that's an improvement task, this is a bug fix!

Status:Needs review» Reviewed & tested by the community

That works, it's not a matter of collapsing/expanding details element, it's a matter of showing them or not to begin with. That works.

Status:Reviewed & tested by the community» Fixed

Committed and pushed to 8.x. Thanks!

Issue tags:-sprint

Hurray! :)

Automatically closed -- issue fixed for 2 weeks with no activity.