First of all, thanks for this great module!

I have a proposal for a minor addition. When using hook_physical_dimension_info_alter() to change the order of the dimensions and/or rename one or more dimensions names, things get mixed up in the widget form. Currently there is the underlying assumption, that the height field is the last one and should therefore be suffixed with the dimension unit if the unit itself is not selectable. It would be better to drop that assumption and to simply add the suffix to the last field. See the patch.

CommentFileSizeAuthor
physical-drop-order-assumption-1.patch869 bytesberliner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

berliner’s picture

Status: Active » Needs review
rszrama’s picture

Category: Bug report » Task
Priority: Minor » Normal
Issue summary: View changes
Status: Needs review » Fixed

Good catch. Committed.

  • rszrama committed e07cf44 on 7.x-1.x authored by berliner
    Issue #2108975 by berliner: remove a fixed reference to the height...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.