Some time the past few weeks, the testbot stopped downloading media's hard dependencies (file_entity or views)

Maybe a dependency rebuild would solve this?

https://qa.drupal.org/pifr/test/158824
Media's info file.
http://drupalcode.org/project/media.git/blob/5839787d839fe880d9334d3f4c3...

even weird: the alpha2 version test download the dependencies normally
https://qa.drupal.org/pifr/test/607848

Comments

Dave Reid’s picture

I filed #2067261: Rebuild dependencies for Media (missing File entity 2.x dependency) a while ago but it appears it did not resolve the issue. This is at least the third time the testbot has regressed for us. :/ (#1802156)

rfay’s picture

Status: Active » Fixed

The dependencies were in fact completely empty, now after a rebuild:

+ /var/www/drupal.org/tools/drush5/drush -r /var/www/drupal.org/htdocs pdsd media 7.x-2.x-dev
Array
(
    [2067673] => Array
        (
            [uri] => file_entity
            [version] => 7.x-2.0-alpha2
            [tag] => 7.x-2.0-alpha2
            [dependency_type] => 0
        )

    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
            [dependency_type] => 0
        )

    [1801458] => Array
        (
            [uri] => wysiwyg
            [version] => 7.x-2.2
            [tag] => 7.x-2.2
            [dependency_type] => 0
        )

    [1965242] => Array
        (
            [uri] => views
            [version] => 7.x-3.7
            [tag] => 7.x-3.7
            [dependency_type] => 0
        )

)
jthorson’s picture

Status: Fixed » Active

s/testbot/project_dependency. The testbots cause enough problems on their own that they don't need to assume credit for issues caused elsewhere. ;)

Dependencies rebuilt. Do these look correct?

EDIT: Beat to the punch. Removing duplicate array text.

jthorson’s picture

Status: Active » Fixed

Crosspost

ParisLiakos’s picture

back to green:)
thanks a lot that was quick!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

ParisLiakos’s picture

can we have a dependency rebuild again please? i have added token module as test_dependency a few days now (e7be30f), but bot doesnt check it out. I have no clue how to trigger a rebuild manually. shouldnt a new commit trigger it? or the fact the a new .dev release was packaged?

ParisLiakos’s picture

Status: Closed (fixed) » Active

let me know if i should open a new issue

rfay’s picture

Title: Media's 2.x dependencies are not being downloaded » Media's 7.x-2.x dependencies are not being downloaded

You really should open a new issue for a new event.

I took a look at this and after rebuild media's dependencies come out empty. None at all.

I have no idea why that would be.

rfay’s picture

Do you *really* depend on token module for tests? It's still just a UI right? Not that I can see anything wrong with what you've done.

ParisLiakos’s picture

its more than UI unfortunately. it provides field tokens that core does not. And we have a usecase we need to test eg that fields attached to a file entity can be overriden in WYSIWYG and the overrides display correctly.
related issue #2116451: Add test coverage for JSON placeholder rendering
I introduce a test there, which has token as dependency, but it never runs unfortunately. i am quite stuck :/

thanks for your time

rfay’s picture

I'm unable to recreate this on qa6-drupal. The dependency build works fine. I'm going to have to rebuild that thing and see what might be different about the db.

rfay’s picture

I'm unable to recreate this on a local machine with a current drupal.org database either (and a current checkout from bzr).

Also, drush pdsd shows the correct values when I dump the project_dependency tables off of util and load them onto my local.

Suggestions of what could be different on production are very welcome. Drush5 hasn't *changed* over there. It *appears* to go through the whole process successfully.

rfay’s picture

Here is the actual situation on util on the live db.

mysql> SELECT * FROM project_dependency_dependency where component_id=778249;
+---------------+--------------+-------------+----------+----------+----------------------+-----------------+
| dependency_id | component_id | dependency  | core_api | external | external_release_nid | dependency_type |
+---------------+--------------+-------------+----------+----------+----------------------+-----------------+
|       1475093 |       778249 | file_entity | 7.x      |        1 |                    0 |               0 |
|       1475095 |       778249 | image       | 7.x      |        1 |                    0 |               0 |
|       1475099 |       778249 | token       | 7.x      |        1 |                    0 |               1 |
|       1475097 |       778249 | views       | 7.x      |        1 |                    0 |               0 |
+---------------+--------------+-------------+----------+----------+----------------------+-----------------+

So it looks to me like the problem is somewhere in the calculation, not the creation of the data in the db. But it's something local to the d.o environment. Probably doesn't have to do with drush pdsd, but rather the things it calls.

rfay’s picture

It seems to me like it's a waste to work on this right now with the D7 push in 2 days. I'm going to leave it alone until after the upgrade, and we'll see what happens then. Fire and brimstone, I imagine.

If you don't see me pick it up by next week, ping me here.

ParisLiakos’s picture

thanks! i agree, D7 upgrade is far more important. good luck!

jthorson’s picture

For what it's worth, here's the current output on the Drupal.org D7 test site.

That said, I don't know how recent the data in the table would be.

$ drush pdsd media 7.x-2.x-dev
Array
(
    [2067673] => Array
        (
            [uri] => file_entity
            [version] => 7.x-2.0-alpha2
            [tag] => 7.x-2.0-alpha2
            [dependency_type] => 0
        )

    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
            [dependency_type] => 0
        )

    [1801458] => Array
        (
            [uri] => wysiwyg
            [version] => 7.x-2.2
            [tag] => 7.x-2.2
            [dependency_type] => 0
        )

    [1965242] => Array
        (
            [uri] => views
            [version] => 7.x-3.7
            [tag] => 7.x-3.7
            [dependency_type] => 0
        )

)
rfay’s picture

If you have a chance (and have permissions). please do a drush pdpp media so that it updates, and then do the drush pdsd media 7.x-2.x-dev again. That will get completely current data. The pdpp must be done as the appropriate user...

jthorson’s picture

7.x version looks good!

$ drush pdsd media 7.x-2.x-dev
Array
(
    [2067673] => Array
        (
            [uri] => file_entity
            [version] => 7.x-2.0-alpha2
            [tag] => 7.x-2.0-alpha2
            [dependency_type] => 0
        )

    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
            [dependency_type] => 0
        )

    [1801458] => Array
        (
            [uri] => wysiwyg
            [version] => 7.x-2.2
            [tag] => 7.x-2.2
            [dependency_type] => 0
        )

    [1925724] => Array
        (
            [uri] => token
            [version] => 7.x-1.5
            [tag] => 7.x-1.5
            [dependency_type] => 1
        )

    [1965242] => Array
        (
            [uri] => views
            [version] => 7.x-3.7
            [tag] => 7.x-3.7
            [dependency_type] => 0
        )

)
ParisLiakos’s picture

thanks but seems that somehow it only checkouts media again:
https://qa.drupal.org/pifr/test/158824 :/

rfay’s picture

@ParisLiakos, Drupal.org is still on 6.x. It goes to 7 tomorrow. The hope (bolstered by @jthorson) is that whatever this oddity is, it will go away on 7.x.

ParisLiakos’s picture

ah! sorry, i thought #19 referred to the 6.x version ;)
i should pay more attention

rfay’s picture

I rebuilt today and it looks good to me (on D7). Hopefully it will stick this time. Given the number of times this has happened in the past, it's my bet there's some obscure bug that only gets reported on media. So it's possible we'll see it again.

(
    [2120857] => Array
        (
            [uri] => file_entity
            [version] => 7.x-2.0-alpha3
            [tag] => 7.x-2.0-alpha3
            [dependency_type] => 0
        )

    [1738460] => Array
        (
            [uri] => ctools
            [version] => 7.x-1.2
            [tag] => 7.x-1.2
            [dependency_type] => 0
        )

    [1801458] => Array
        (
            [uri] => wysiwyg
            [version] => 7.x-2.2
            [tag] => 7.x-2.2
            [dependency_type] => 0
        )

    [1925724] => Array
        (
            [uri] => token
            [version] => 7.x-1.5
            [tag] => 7.x-1.5
            [dependency_type] => 1
        )

    [1965242] => Array
        (
            [uri] => views
            [version] => 7.x-3.7
            [tag] => 7.x-3.7
            [dependency_type] => 0
        )

)
rfay’s picture

Issue summary: View changes
Status: Active » Fixed
rfay’s picture

Status: Fixed » Active

Oops, since adding token as test_dependency and it seems not to show token as a dependency, now we have a different problem.

jthorson’s picture

I assumed 'dependency_type' => 1 was a test_dependency ... is that not true?

ParisLiakos’s picture

thanks, seems all dependencies check out as should now.
and yes token is indeed a test_dependency, not a normal one

rfay’s picture

Status: Active » Fixed

I was just hallucinating. Returned to this and it looked good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.