[tsm] manual review

• You have a leading blank line at the top of the .info file.
• The uninstall hook should delete all variables used, missing
  • httprl_background_callback
  • httprl_dns_timeout
  • httprl_connect_timeout
  • httprl_ttfb_timeout
  • httprl_timeout
  • httprl_global_timeout
  • httprl_url_inbound_alter
• There's many places that check to make sure the Drupal version is >= 7, that could be refactored in both the d6 and d7 versions.
• In httprl_build_url_self() you have an empty if (empty($path_parts)) { // Bail out here. } - should that do something, or can it be removed?
• This is repeated a few times, consider refactoring or using a ternary operator instead $t = function_exists('t') ? 't' : 'httprl_pr';
  

    if (function_exists('t')) {
      $t = 't';
    }
    else {
      $t = 'httprl_pr';
    }
  

• In httprl_set_connection_flag(), start with $flags = STREAM_CLIENT_CONNECT; and the if blocks can be much simpler.
• In httprl_handle_data(), instead of $temp = $info; unset($info); $info[] = $temp;, $info = array($info); should be sufficient. Similarly in httprl_request().
• httprl_send_request() is almost 500 LoC. Consider refactoring into smaller functions.
• Instead of httprl_strlen(), how about using drupal_strlen()?
• I don't see where the "Reset to defaults" button is defined for httprl_admin_settings_form_validate()?

What do you think?

----
Top Shelf Modules - Crafted, Curated, Contributed.