Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Patch is coming. You should remove the master branch.
Comment | File | Size | Author |
---|---|---|---|
#1 | 2111099-1-pareview.patch | 24.79 KB | kscheirer |
Comments
Comment #1
kscheirerPatch attached.
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia commentedThanks kscheirer!
Why remove views_accordion.views.inc from files[] ¿?
I see the plugin stil works so views picks it up automatically, stil just wondering why remove it...
Comment #3
Manuel Garcia CreditAttribution: Manuel Garcia commentedHumm I tried deleting the master branch as you suggested (not used anyway), but the change got rejected somehow... not sure why it says that By default, deleting the current branch is denied, since i had checked out to 7.x before deleting the branch...
Comment #4
kscheirerHmm, that is weird. It doesn't hurt to leave it of course. I'll do some research and see if I can find anything for you.
As for the .info file, technically the files[] directive is for "code files containing class or interface declarations." See https://drupal.org/node/542202#files. Not a big deal of course, just general cleanup :)
Comment #5
kscheirerDoes this help? https://drupal.org/node/1127732
Comment #6
Manuel Garcia CreditAttribution: Manuel Garcia commentedThanks kscheirer for the clarification, committed to 7.x-1.x with attribution.
As for the master branch, very weird, none of the dev are using the master branch, but when i try pushing the deleted branch back to origin i get the above message "By default, deleting the current branch is denied".
So I decided to just empty the master branch and leave a README.txt file clarifying that it's not used.
Comment #7
kscheirerWorks for me, thanks!