In #1827112: Convert 'install_profile' variable to Settings we forgot to update the function doc block fordrupal_get_profile()

Critical because we mention variable_get() :)

Part of #1775842: [meta] Convert all variables to state and/or config systems

Files: 
CommentFileSizeAuthor
#4 2112261.4.patch795 bytesalexpott
PASSED: [[SimpleTest]]: [MySQL] 59,416 pass(es).
[ View ]
#2 2112261.2.patch793 bytesalexpott
PASSED: [[SimpleTest]]: [MySQL] 59,359 pass(es).
[ View ]
#1 2112261.1.patch820 bytesalexpott
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Comments

Status:Active» Needs review
StatusFileSize
new820 bytes
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]

Here's a patch

StatusFileSize
new793 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,359 pass(es).
[ View ]

Don't really like the test in #1 it's too verbose and doesn't really add value.

  1. +++ b/core/includes/common.inc
    @@ -260,9 +260,8 @@ function drupal_get_region_content($region = NULL, $delimiter = ' ') {
    + * installation state. At all other times, the install_profile setting will be

    Should we wrap this setting name in quotes?

  2. +++ b/core/includes/common.inc
    @@ -260,9 +260,8 @@ function drupal_get_region_content($region = NULL, $delimiter = ' ') {
    + * available in settings.php.

    Howcome you changed from using settings() to settings.php - out of interest :)

StatusFileSize
new795 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,416 pass(es).
[ View ]

1. Sure
2. Because everyone knows where their settings.php file is :)

Status:Needs review» Reviewed & tested by the community

2. zing! Sounds fair to me :)

Status:Reviewed & tested by the community» Fixed

Thanks! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue summary:View changes

Updated issue summary.