Problem/Motivation

The content translation form now includes duplicate labels for some of the items listed. But not all of them:

ExtraContentLabels.png

Entity types are lowercase, so even looks uglier. However, none of these extra labels are needed at all. The markup / table render contains all sufficient labels in the next column of the table and that is properly cross references with <label for=""></label> tags. Also those labels are accessible including the full hierarchy of items like so:

<label for="edit-settings-node-article-columns-field-image-file"><span class="visually-hidden">Article</span> <span class="visually-hidden">Image</span> File</label>

Proposed resolution

So the "randomly" displayed labels right next to checkboxes are absolutely superfluous and should go away as they were before. The original version of the form did not include these and the appearance of them is a regression. Resulting table:

ContentLabelsAfter.png

Remaining tasks

Review, commit :)

User interface changes

Clean translation configuration table.

API changes

None.

Files: 
CommentFileSizeAuthor
ContentLabelsAfter.png71.01 KBGábor Hojtsy
ExtraContentLabels.png114.82 KBGábor Hojtsy
extra-random-labels.patch1.15 KBGábor Hojtsy
PASSED: [[SimpleTest]]: [MySQL] 59,054 pass(es).
[ View ]

Comments

Issue tags:+regression

Issue tags:+accesssibility

Also an accessibility problem that the extra labels lack crucial information about the structure of the form that are otherwise included with the labels later on. With having two labels marked up for the same checkboxes, it is up to browsers to pick and picking the extra ones reduces accessibility a great deal. :/

Status:Needs review» Reviewed & tested by the community

I tried this out on simplytest.me
works great.

+1 for the RTBC.

Issue tags:+Quick fix

Issue tags:-Quick fix

extra-random-labels.patch queued for re-testing.

Status:Reviewed & tested by the community» Fixed

Uhm, wow, that's pretty awful! Glad the fix is so easy. :)

Committed and pushed to 8.x. Thanks!

Issue tags:-sprint

Yay, thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.