If someone has not commented on an issue but is assigned the issue should that issue show up in "my issues" ?

On Drupal 7 the behavior is currently not to include those issues. Is that the same as D6? Is that desirable behavior? I think it would be nice to show things that are assigned to a user as well even if they never commented on them.

CommentFileSizeAuthor
#5 project_issue-assigned_user-2112421-5.patch1.22 KBsanchiz
#4 project_issue-assigned_user-2112421-4.patch661 bytessanchiz

Comments

dww’s picture

dww
we/he/they
commented

It should be the case that when an issue is assigned to you, you automatically start following it. "My issues" always means "Issues I'm following". So, if this is broken, it's broken. AFAIK, the behavior shouldn't have changed.

drumm’s picture

drumm
he/him
Location NY, US
commented

That's all true, except we don't have auto-following when someone else assigns you to an issue.

dww’s picture

dww
we/he/they
commented
Title: Definition of "my issues" » Regression: assigned user is no longer automatically following the issue
Category: Support request » Bug report
Issue summary: View changes
Issue tags: +Drupal.org 7.1
Parent issue: » #1560010: [META] Port issue following functionality to D7

We used to. If that's no longer happening, it's a D7 regression.

D6 includes/comment.inc:

        // Auto-flag the issue for the comment author and the current assignee.
        project_issue_flag_issue($arg['nid'], $arg['uid']);
        if (!empty($arg['project_info']['assigned'])) {
          project_issue_flag_issue($arg['nid'], $arg['project_info']['assigned']);
        }

I think we failed to port that or leave a TODO about it during the flag_tracker stuff from #1560010: [META] Port issue following functionality to D7

Not sure if the fix is a special-case in project_issue or something we should handle in flag_tracker. Seems better to teach project_issue about flag_tracker than the other way around, so leaving it in this queue.

sanchiz’s picture

sanchiz commented
Status: Active » Needs review
StatusFileSize
new project_issue-assigned_user-2112421-4.patch661 bytes

Initial patch.

sanchiz’s picture

sanchiz commented
StatusFileSize
new project_issue-assigned_user-2112421-5.patch1.22 KB

Fixed assigning on update and insert.

drumm’s picture

drumm
he/him
Location NY, US
commented

Looks okay. The duplicated code isn't ideal, we might want to pull this out into a new function, but I don't think that's necessary. Leaving for dww to review.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Fixed

Thanks! Tested and working nicely. Committed and pushed:

http://drupalcode.org/project/project_issue.git/commit/9870360

Did a minor code-cleanup and simplification:

http://drupalcode.org/project/project_issue.git/commit/66bafcc

Realized I pushed with a syntax error. Tee hee:

http://drupalcode.org/project/project_issue.git/commit/e9a1542

Tested again on my dev site and all is well, so I deployed live.

Thanks again!
-Derek

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.