Patch forthcoming for some minor coding standards changes for these files based on Coder's Coder Sniffer.

CommentFileSizeAuthor
#1 file_entity-themetokenpathauto_coding_standards-2113287-1.patch3.45 KBbneil
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bneil’s picture

bneil CreditAttribution: bneil commented
Title: file_entity.theme.inc coding standards cleanup » file_entity theme.inc, tokens.inc, and pathauto.inc coding standards cleanup
Assigned: bneil » Unassigned
Status: Active » Needs review
FileSize
file_entity-themetokenpathauto_coding_standards-2113287-1.patch3.45 KB

Fixed

FILE: .../media_dev/profiles/media_dev/modules/file_entity/file_entity.theme.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AND 2 WARNING(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
  56 | ERROR   | Inline comments must end in full-stops, exclamation marks, or
     |         | question marks
  75 | ERROR   | Missing parameter type at position 1
  79 | WARNING | Line exceeds 80 characters; contains 96 characters
 114 | ERROR   | Missing parameter type at position 1
 118 | WARNING | Line exceeds 80 characters; contains 96 characters
--------------------------------------------------------------------------------

FILE: ...dia_dev/profiles/media_dev/modules/file_entity/file_entity.pathauto.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 37 | ERROR | Case breaking statements must be followed by a single blank line
--------------------------------------------------------------------------------
FILE: file_entity.tokens.inc
--------------------------------------------------------------------------------
FOUND 3 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
110 | ERROR | Case breaking statements must be followed by a single blank line
114 | ERROR | Case breaking statements must be followed by a single blank line
121 | ERROR | Case breaking statements must be followed by a single blank line
--------------------------------------------------------------------------------
Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Status: Needs review » Fixed

#1 looks good.

Committed to File entity 7.x-2.x.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Fixed » Needs review

#1: file_entity-themetokenpathauto_coding_standards-2113287-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, file_entity-themetokenpathauto_coding_standards-2113287-1.patch, failed testing.

bneil’s picture

bneil CreditAttribution: bneil commented

I see the patch got committed then retested. Is there any action that I need to do here?

  • Devin Carlson committed 92b8170 on 8.x-2.x authored by bneil 
    Issue #2113287 by bneil: Fixed coding standards issues in file_entity....
Devin Carlson’s picture

Devin Carlson CreditAttribution: Devin Carlson commented
Issue summary: View changes
Status: Needs work » Closed (fixed)