Prioritize order of authentication servers based on past logins [#2115591]

This is a spin-off of the work done on #1740978: LDAP Authentication and LDAP User: LDAP not allowing to authenticate to multiple servers.

When you have multiple servers handling authentication for different domains it can be beneficial from a performance standpoint for the LDAP module to prioritize the order in which it queries the LDAP servers based on the last known success for a user.

For example:

We have 2 LDAP servers managing two completely independent domains.
When a user logs in, if they belong to the 2nd domain they still get an authentication check against the 1st domain.

This patch adds a bit of logic to the ldap_authentication.inc file to detect if their are multiple servers defined and if the user has previously had a successful login. If these two conditions are met, the patch changes the order of the $auth_conf->enabledAuthenticationServers array so that the server they last successfully authenticated against is the first server tried during this login attempt.

Comment	File	Size	Author
	ldap-prioritylogin.patch	1.49 KB	shawn_smiley
	7.x-2.x: PHP 5.4 & MySQL 5.5, D7 21 pass PHP 5.5 & MySQL 5.5, D7 21 pass PHP 5.6 & MySQL 5.5, D7 21 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

johnbarclay CreditAttribution: johnbarclay commented 22 October 2013 at 14:58

I agree with the spirit/essence of the patch, but have not tested it. I'll commit it after more testing/review. Thanks.

Comment #2

larowlan

🇦🇺🏝.au GMT+10

CreditAttribution: larowlan at PreviousNext commented 11 March 2016 at 04:09

Issue summary:	View changes
Status:	Needs review	» Needs work

Looks good, just a couple of nitpicks

+++ b/ldap_authentication/ldap_authentication.inc
@@ -208,6 +208,22 @@ function _ldap_authentication_user_login_authenticate_validate(&$form_state, $re
+    if ($auth_conf->ldapUser->drupalAcctProvisionServer == LDAP_USER_AUTH_SERVER_SID) {

This should be ===

+++ b/ldap_authentication/ldap_authentication.inc
@@ -208,6 +208,22 @@ function _ldap_authentication_user_login_authenticate_validate(&$form_state, $re
+      if ($preferred_sid && $preferred_sid != LDAP_USER_AUTH_SERVER_SID && isset($auth_conf->sids[$preferred_sid])) {

!==