Problem/Motivation

If a user searches in the normal user search for a realname provided by the realname module, the realname module cannot alter the search query and is not able to join the realname table to make a LIKE on the realname table. This is blocking development of #1409314: User Search does not Search Real Names.

Proposed resolution

Add the tag 'user_search' to the user_search_execute() query.

Remaining tasks

Commit the attached patches.

User interface changes

None

API changes

None

CommentFileSizeAuthor
#10 Issue-2116391-Tag-usersearchexecute-query-for-realname-D7.patch862 byteshass
#9 Issue-2116391-Tag-usersearchexecute-query-for-realna.patch862 byteshass
#6 Tag-the-user-search-query-D8-2116391-6.patch721 bytesadci_contributor
#1 Issue--by-hass-Tag-the-user-search-query-to-allow-query-alter-D7-do-not-test.patch870 byteshass
Issue--by-hass-Tag-the-user-search-query-to-allow-query-alter-D8.patch999 byteshass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented
Issue tags: +Needs backport to 7.x
FileSize
Issue--by-hass-Tag-the-user-search-query-to-allow-query-alter-D7-do-not-test.patch870 bytes

Also attaching the D7 patch.

hass’s picture

hass CreditAttribution: hass commented
Issue summary: View changes

Bumping

hass’s picture

hass CreditAttribution: hass commented
Category: Task » Bug report
Priority: Normal » Major
Issue tags: -

hass queued Issue--by-hass-Tag-the-user-search-query-to-allow-query-alter-D8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, Issue--by-hass-Tag-the-user-search-query-to-allow-query-alter-D8.patch, failed testing.

adci_contributor’s picture

adci_contributor CreditAttribution: adci_contributor commented
Status: Needs work » Needs review
FileSize
Tag-the-user-search-query-D8-2116391-6.patch721 bytes

Trying to reroll

hass’s picture

hass CreditAttribution: hass commented
Related issues: +#2364069: Search specific tags are not available and hook_query_TAG_alter hooks are not invoked (forward-port the tests)
hass’s picture

hass CreditAttribution: hass commented
Related issues: +#2117881: How extend query conditions via hook_query_alter()?
hass’s picture

hass CreditAttribution: hass commented
FileSize
Issue-2116391-Tag-usersearchexecute-query-for-realna.patch862 bytes

With #2364069: Search specific tags are not available and hook_query_TAG_alter hooks are not invoked (forward-port the tests) in mind a new patch with changed tag name search_user.

hass’s picture

hass CreditAttribution: hass commented
Version: 8.0.x-dev » 7.x-dev
FileSize
Issue-2116391-Tag-usersearchexecute-query-for-realname-D7.patch862 bytes

The last submitted patch, 9: Issue-2116391-Tag-usersearchexecute-query-for-realna.patch, failed testing.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC, looks good to me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 10: Issue-2116391-Tag-usersearchexecute-query-for-realname-D7.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Reviewed & tested by the community

Test bot issue

hass queued 10: Issue-2116391-Tag-usersearchexecute-query-for-realname-D7.patch for re-testing.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Version: 7.x-dev » 8.0.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs backport to D7

This looks good, but it was originally filed as a patch for Drupal 8, and looks like it's still relevant there too, right?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Category: Bug report » Task
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 8.0.x-dev » 8.2.x-dev
Component: user.module » search.module
Category: Task » Feature request

Just as a note, normally things related to searching are put into the search.module component, to come to the attention of the Search maintainers.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.