Let's figure out wether

      static::$propertyDefinitions[$key]['label'] = array(
        'type' => 'string',
        'label' => t('Label (auto-create)'),
        'computed' => TRUE,
      );
      static::$propertyDefinitions[$key]['access'] = array(
        'type' => 'boolean',
        'label' => t('Access'),
        'computed' => TRUE,
      );

is necessary for configurable entity reference field item.

Related issue:
#2015687: Convert field type to FieldType plugin for taxonomy module

CommentFileSizeAuthor
#1 2117635.patch801 bytesamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Title: clean configurable entity reference field item's $propertyDefinitions. » Clean up ConfigEntityReferenceItemBase::getPropertyDefinitions()
Status: Active » Needs review
FileSize
2117635.patch801 bytes

Ran the ER tests locally and they pass, so it seems that those extra properties are indeed not needed anymore.

smiletrl’s picture

smiletrl CreditAttribution: smiletrl commented

Thanks for testing that!

Maybe we could incorporate this patch into #2015687: Convert field type to FieldType plugin for taxonomy module , and close this one?

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs review » Closed (duplicate)

Sure, I'm always in favor of less patches.