Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#13 | interdiff.txt | 1.59 KB | Gábor Hojtsy |
#13 | date-format-test-13.patch | 4.51 KB | Gábor Hojtsy |
#8 | date-format-test-8.patch | 4.49 KB | penyaskito |
#8 | interdiff.txt | 1.29 KB | penyaskito |
#6 | interdiff.txt | 2.14 KB | Gábor Hojtsy |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedComment #2
YesCT CreditAttribution: YesCT commentedthat got in! yay.
Comment #3
Gábor HojtsyHere is a first stab at this.
Comment #4
Gábor HojtsyAgain, my non-whitespace whitespaces....
Comment #5
YesCT CreditAttribution: YesCT commentedabove, it is testing all the hidden languages (or all those from core).
But the date formats are only testing a couple of the hidden ones. A comment here about that might be more clear.
Something like:
// Hidden date formats are only available to translate through the configuration translation listings. Test a couple of them.
strictly speaking I think we should make our own format unless we are testing specifically translating built in formats.
oh, maybe here we are now testing that we can translate a default format and a custom one. Oh, no. Well. medium is a default format, but not a hidden system one.
how is asserting label checking if the original text is present?
no patch now. gotta run.
Comment #6
Gábor Hojtsy1. Fixed in patch update.
2/3. We *are* testing both a core shipped format (medium) and a custom added one (custom_medium). I don't think there is anything actionable on these points then :)
4. The label of the date format as saved originally is displayed as the original value on the form. It is true I have only been testing the custom label and that will not show up on both translation forms. Fixed that :)
Comment #8
penyaskitoStill failing locally, but some issues fixed.
Comment #9
penyaskitoComment #11
Gábor Hojtsy8: date-format-test-8.patch queued for re-testing.
Comment #13
Gábor Hojtsylocale.config.typed cannot be used with config which was not shipped with a module. I think this is probably resolved with #1966538: Translation is not updated for configuration, when the config changes. Anyway, we can use the same file storage based checking technique that other tests use in this function.
Comment #14
Gábor HojtsyYay, committed/pushed #13.
Comment #15
penyaskitow00t!