For some reason, during the upgrade to rc5, our Aegir server decided to verify *all* sites, including deleted sites!

Ouch?

Comments

anarcat’s picture

I think this is the cause:

/**
* Fixup redirection data after table change in hosting_alias_update_6203()
*/
function hosting_alias_update_6204() {
  $ret = array();
  $result = db_query("SELECT `nid` FROM {hosting_site_alias} WHERE `redirection`=1");
  while ($obj = db_fetch_object($result)) {
    $node = node_load($obj->nid);
    if (is_object($node)) {
      $node->redirection = $node->title;
      hosting_alias_update($node);

      // Run a verify task to update the vhost
      hosting_add_task($node->nid, 'verify');
    }
  }

  return $ret;
}

anarcat’s picture

Status: Active » Fixed

i think i fixed this in commit 724c836:

commit 724c8360f3428fc799e02a6403034823d74361f4
Author: Antoine Beaupré <anarcat@koumbit.org>
Date:   Wed Oct 23 19:34:07 2013 -0400

    don't verify deleted sites, fixes #2119111

diff --git a/alias/hosting_alias.install b/alias/hosting_alias.install
index 68d8914..5b4da5f 100644
--- a/alias/hosting_alias.install
+++ b/alias/hosting_alias.install
@@ -100,7 +100,7 @@ function hosting_alias_update_6203() {
 */
 function hosting_alias_update_6204() {
   $ret = array();
-  $result = db_query("SELECT `nid` FROM {hosting_site_alias} WHERE `redirection`=1");
+  $result = db_query("SELECT nid FROM {hosting_site_alias} INNER JOIN hosting_site site ON site.nid = alias.nid WHERE redirection=1 AND site.status>-2");
   while ($obj = db_fetch_object($result)) {
     $node = node_load($obj->nid);
     if (is_object($node)) {

testing would be appreciated.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 8d03a59 on 6.x-2.x, 7.x-3.x, dev-sni, dev-helmo-3.x by anarcat:
    don't verify deleted sites, fixes #2119111
    

  • Commit 8d03a59 on 6.x-2.x, 7.x-3.x, dev-sni, dev-helmo-3.x by anarcat:
    don't verify deleted sites, fixes #2119111