Project Page: https://drupal.org/sandbox/michaelhodgejr/2113571
Git Repository: git clone http://git.drupal.org/sandbox/michaelhodgejr/2113571.git tweet_embed

Description

This module creates an input filter that will transform links such as https://twitter.com/lightsky_design/status/393350560902295553 into an Embedded Tweet. It was created as a way to make it easy for content editors to easily embed tweets within their site.

Reviews of other applications

[D7] Get Total - https://drupal.org/node/2122451#comment-8009271
[D7] Menu CSS - https://drupal.org/node/2122649#comment-8009325
[D7] mailredirec7 - https://drupal.org/node/2121197#comment-8009371

Comments

Status:Active» Needs review

I guess this needs review? See our workflow: https://drupal.org/node/532400

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

@klausi - Yes, my apologies. I forgot to change the status when submitting.

Status:Needs review» Needs work

Thank you for your contribution. Looks like a good functionality to have. Here are my findings:

AUTOMATED REVIEW:

pareview reports some issues http://pareview.sh/pareview/httpgitdrupalorgsandboxmichaelhodgejr2113571git, please clear those up.

MANUAL REVIEW:

  • Change the git clone link in the issue summary to the non maintainer version. The current link will only work for you.
  • Similar module
    Twitter Input Filter module is similar but is only for D6. It shows the Maintenance status and Development Status as unknown. Maybe you could also put in a request to maintain that in D6 (if you have experience working with it).
  • Lines of code:

    We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed, that means we can't make sure you're able to write secure code and use Drupal's APIs correctly.
    If this is the case, we can't approve you as git vetted user (giving you the permission to create full projects). Either we can see that you have the needed knowledge by other contributions within the drupal community or we can promote it to a full project manually.

    Maybe you could add hook_help() and some more inline comments which could get you past the current benchmark.
    However, this is a nice functionality and doesn't seem to be present with any other project; so I would vote this to be an promoted to full project.

Thanks for your feedback. I will go through and fix the issues with the report. I will also add a module settings form. This will allow the user to specify the defaults as well as help bring me over the minimum code requirement.

I've fixed the automated errors.

I also went in and adding a module settings page to control the default parameter settings. This not only makes it easier for the user, but also puts me in well over the minimum code requirement.

Please review and let me know your thoughts.

Thanks!

-Mike

Issue summary:View changes

updated git repo url

Issue summary:View changes

added review bonus section

Issue summary:View changes

added second review bonus

Issue summary:View changes

added third review bonus

Status:Needs work» Needs review

I've added a README.txt file to the application.

Added review bonus tag

Status:Needs review» Reviewed & tested by the community

AUTOMATED REVIEW:
pareview reports no issues

MANUAL REVIEW:

  • No issues found going through the project application checklist
  • README.txt is easy to follow and understand

I have one suggestion, but it in no way affects the operation of the module.

On your admin/config/services/tweet_embed page, it might be helpful to provide an example under each default of how to manually override the default setting. A link to the available options for each setting might be good as well.

Overall, a nice module. I'll remember this the next time I need to embed Tweets.

Status:Reviewed & tested by the community» Postponed (maintainer needs more info)

This sounds like a feature that should live in the existing twitter project. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. Please open an issue in the twitter issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward. If you cannot reach the maintainer(s) please follow the abandoned project process.

There is already an issue to create an input filter: #1365452: Embedded Tweets input filter

If that fails for whatever reason please get back to us and set this back to "needs review".

Issue summary:View changes

changed section title

Issue summary:View changes
Status:Postponed (maintainer needs more info)» Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.