I looked through some recent issues to see if this had been reported yet, but didn't see anything. The padding of elements with ids and name attributes is causing issues for selectability, specifically within tables.

body.toolbar-drawer .main-container a[id] {
float: left;
display: inline-block;
margin-top: -59px;
padding-top: 59px;
width: 100%;
}

These links, such as the "configure" and "disable" links in the image below become difficult to select. In order to select the desired link, you must hover approximately 60 pixels above the link, at which point the link you are trying to click will be indicated as being hovered.

draggable-row

Another more minor bug can be seen in draggable rows. The overrides should probably include something to set the proper height of the ".draggable a.tabledrag-handle".

CommentFileSizeAuthor
draggable-row.png8.24 KBJakeWilund
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

smoothify’s picture

Title: Elements with ID Padding » Links and headers with IDs can be malformed by anchor-fix mixin.

I've taken the liberty to rename the title as i believe its the same issue as i've been facing with links in ctools page manager and in ckeditor.

It's noticeable when admin_menu is showing, or if the navbar is sticky as this is when the anchor-fix mixin is active.

Here are some screenshots that show the problem:

Page Manager:
http://www.screencast.com/t/beO8Yr6jjHRo
http://www.screencast.com/t/QKpg49fg

CKEditor
http://www.screencast.com/t/7xCQWK1W
http://www.screencast.com/t/YxMvrtwdUu

JakeWilund’s picture

Thanks smoothify. I knew the title was poorly descriptive, glad somebody else is also aware of this issue.

As I've been working with the theme, I've come across quite a few small bugs that can be easily fixed with some css overrides. What would be the best way to contribute in regards to fixing them? If I created a separate issue for styling bug fixes and then post patches, would that be acceptable?

valkum’s picture

valkum’s picture

Priority: Normal » Critical

I'm not sure. On the origin solutions thread on stackoverflow there is this problem mentioned.
I think as we are javascript dependent we should use a javascript solution.
@markcarver what do you think?

markhalliwell’s picture

Status: Active » Fixed

I've removed the mixin entirely and opted for the JavaScript solution like @valkum suggested. I went ahead and added some theme settings for it too.
Committed 978ff80 to 7.x-3.x:

Issue #2120793 by Mark Carver, JakeWilund: Links and headers with IDs can be malformed by anchor-fix mixin.

JakeWilund’s picture

Great, thanks Mark!

PascalAnimateur’s picture

It should be noted that bootstrap_subtheme should benefit from this as well... files have to be manually updated as of now.
It works fine... it was my subtheme copy that needed updating!

markhalliwell’s picture

Cleaned up and consolidated some of the JS. Fixed non-smooth scrolling scrollTo.
Committed 03b87be to 7.x-3.x:

Issue #2120793 by Mark Carver, JakeWilund: Links and headers with IDs can be malformed by anchor-fix mixin.

markhalliwell’s picture

Committed c1d9f2c to 7.x-3.x:

Issue #2120793 by Mark Carver, JakeWilund: Links and headers with IDs can be malformed by anchor-fix mixin.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.