Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Top Drupal contributor Acquia would like to thank their partners for their contributions to Drupal.
Drupal is a registered trademark of Dries Buytaert.
Comments
Comment #1
nvahalik CreditAttribution: nvahalik commentedHere is the 7.x-2.x version of the patch.
Comment #2
nvahalik CreditAttribution: nvahalik commentedUpdating because of a problem we found testing the module.
Comment #3
nvahalik CreditAttribution: nvahalik commentedActually, here's the correct patch ;)
Comment #4
hass CreditAttribution: hass commented@nvahalik: I'd like to get this in, but are you able to write some tests, please?
Comment #5
hass CreditAttribution: hass commentedAsking me if rules integration makes still sense!?
Comment #6
hass CreditAttribution: hass commentedI found a validation hook in rules API. Maybe this works a bit easier? Changed the patch based on API docs. Fully untested.
I cannot test anything here as I'm blocked by #2306551: Module completly broken, cannot enable.
Comment #7
hass CreditAttribution: hass commentedTests are missing.
Comment #9
hass CreditAttribution: hass commentedLooks like 'validation' functions are not working at all and all 'textfield' are 'text' fields. Also every text field shows a token selector and PHP evaluator under the text fields.
That is really not what we want.
Comment #10
Plazik CreditAttribution: Plazik commentedGA Push module supports Rules integration and works with Universal Analytics.