Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I just installed 7.x-2.0 on a Commerce Kickstart installation and it's behaving very strangely. I wonder if there's something about my site or about the Commerce Kickstart toolbar that isn't playing nicely with EI.
Even though I have chosen "bottom" in the settings for all environments, the bar appears at the top, and the color of all items in the Commerce Kickstart toolbar changes when I hover over it (but goes back to its normal color on page reload). It looks like the new version is supposed to change the color of the admin menu or toolbar by design, but I don't think it's supposed to work like this. And if I have it set for the bottom of the screen, shouldn't it leave the toolbar alone?
The screenshot shows my choice of bottom + fixed position, but I get the same behavior whether I choose fixed or not. I'm assuming that bottom positioning works or someone would have reported it already; if that's the case, what could be interfering on my site?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2121133-document-integration-for-position.patch | 693 bytes | Stevel |
| ei-kickstart.jpg | 46.5 KB | BrightBold |
Comments
Comment #1
Stevel CreditAttribution: Stevel commentedIt looks like you have the Toolbar module enabled. As the EI integrates with Toolbar, it shows up wherever the Toolbar appears. This means the position in the environment settings has no effect.
Comment #2
BrightBoldOK thanks that's helpful. The Commerce Kickstart toolbar appears to be a mod of core Toolbar, rather than its own module, so this explains the behavior. My style modifications are overriding EI's in the toolbar & button backgrounds but not for the hovers, which explains the weird screenshot above. I think for this site I'll have to go back to 1.x and try out 2.x on one of my other sites.
Comment #4
izmeez CreditAttribution: izmeez commentedCame across this when testing version 7.x-2.x today and thought it was strange. It also appears to integrate with the admin_menu when that module is enabled. But, that was precisely why I thought I would try it set to bottom and found it did not behave as expected.
Comment #5
danielphenry CreditAttribution: danielphenry commentedI recommend either the top/bottom setting is respected despite it's integration with the toolbar and admin menu (my preferred solution). Or the documentation be changed to reflect that the setting will be ignored. I spent 20min trying to figure out the 2.0 version conf settings only to discover this gap in the documentation.
Comment #6
Stevel CreditAttribution: Stevel commentedComment #7
Stevel CreditAttribution: Stevel commentedChange to -dev version
Comment #8
e0ipsoFixed, committed and pushed to -dev in this commit.
Many thanks to Stevel and everyone else.
Comment #9
izmeez CreditAttribution: izmeez commentedWell, I appreciate that the documentation is fixed but I feel this issue has been hijacked based on the comments in the opening issue, my comments in #4 and the comments in #5.
All of these point to the fact that the module does not behave the way users expect or want. With the integration of EI with the admin menu users may prefer to use an alternate setting such as bottom but cannot do that.
The documentation fix is just a temporary cover for the fact that the bottom option is not available although it may be preferred to have that option.
I think it would be better if this issue is left as "Needs work" and maybe change the title to "Bottom position has no effect ..."
Comment #10
e0ipso@imeez, please open a feature request for this. I think "Let users opt-out from toolbar integrations" deserves its own issue instead of leaving this here.
As always with new features, patches are welcome!
Thanks for the effort in making the EI better.
Comment #11
izmeez CreditAttribution: izmeez commentedok, I have gone ahead and opened a new issue #2147007: Let users opt-out from toolbar integrations