Currently the Kickstarter installs Features 1.x. We should switch to Features 2.x and update the commerce features to the new "feature syntax". Through the improved UI in Features and the separation of some components (e.g. Field base and Field instances) some things can be better exported into code.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bojanz’s picture

This is probably too big of a change to happen in Kickstart 2.x at this point.
The features 2.x update isn't really a smooth ride for some people (because of the field + field instance separation) and we'd need to figure out how to reroll
our performance patches and custom calls (in the feature install files) that we needed to done in order to make Kickstart install properly with a bunch of features.
That means we need days of resources which we don't have at this point.

bojanz’s picture

Issue summary: View changes
Status: Active » Needs review

This might be possible now.
Lars has been adding Behat tests, and has time to test manually as well.
I've converted the Features patches and custom calls, then re-exported the features.
The PR is up at and will need very careful testing :https://github.com/commerceguys/commerce_kickstart/pull/18

rootwork’s picture

Would love to see this. There's a bug in Features 1.x related to PHP 5.4: #1588596: Notice: Array to string conversion in features_export_prepare() (line 190 of features.export.inc). It's been fixed in 2.x.

Sebastien M.’s picture

I'm too interested by features 2.x.
Can you update this ticket ?

lsolesen’s picture

@Sebastien You are welcome to finish @bojanz work :) And help testing the current changes.

lsolesen’s picture

chrisolof’s picture

As someone who cringes when config isn't held in code I'd love to see Kickstart move to features 2.x. The 1.x interface is a real pain in comparison.

Looks like this pull request might do it?
https://github.com/commerceguys/commerce_kickstart/pull/74

lsolesen’s picture

@chrisolof There is still a couple of hickups with the pull request. If you have time to fix those, we would love to get it committed.

jantoine’s picture

Below are instructions for creating a patch against the latest release. I have attached a patch for 7.x-2.21.

  1. Clone the d.o Commerce Kickstart repository:
    git clone --branch 7.x-2.x http://git.drupal.org/project/commerce_kickstart.git
    cd commerce_kickstart
  2. Add lsolesen's Commerce Kickstart repository as a remote:
    git remote add lsolesen https://github.com/lsolesen/commerce_kickstart.git
    git fetch lsolesen
  3. Checkout the latest release branch:
    git checkout -b 7.x-2.21 7.x-2.21
  4. Build the project:
    scripts/build.sh 7.x-2.21
    rm -fr 7.x-2.21/profiles/commerce_kickstart/.git
    mv 7.x-2.21 ../
  5. Create a repository to diff against:
    cd ../7.x-2.21
    git init
    git add -A
    git commit -m "- Initial commit."
    cd ../commerce_kickstart/
  6. Checkout lsolesen's features2-image-field branch:
    git checkout -b features2-image-field lsolesen/features2-image-field
  7. Rebase lsolesen's features2-image-field branch against the latest release branch:
    git rebase --onto 7.x-2.21 7.x-2.x features2-image-field
  8. Build the project:
    scripts/build.sh 7.x-2.21-features2
    rm -fr 7.x-2.21-features2/profiles/commerce_kickstart/.git
    mv 7.x-2.21-features2 ../
  9. Copy 7.x-2.21-features2 files into the 7.x-2.21 folder:
    cp -r ../7.x-2.21-features2/. ../7.x-2.21
  10. Create the patch:
    cd ../7.x-2.21
    git add -A
    git diff --cached > ../commerce-kickstart-features2.patch
    remove all hunks for .info files where the only thing that changed was the timestamp
candelas’s picture

Hello

Does it works with Commerce Kickstart 2.22? Thanks

candelas’s picture

I add this errors that I get in a fresh 2.22 install on features.

bojanz’s picture

Status: Needs review » Fixed

Merged in https://github.com/commerceguys/commerce_kickstart/pull/105.
Thank you, lsolesen and mglaman!

  • bojanz committed 20fa812 on 7.x-2.x
    Merge pull request #105 from mglaman/features-2.x-2229673
    
    Issue #...
  • mglaman committed 2eb3096 on 7.x-2.x
    Issue #2122045 - Move to Features 2.x
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.