The totals of the cart item amounts do not match order amounts - Commerce Paypal(EC) + Commerce Multicurrency

In functions:

function commerce_paypal_ec_set_express_checkout($payment_method, $order, $flow)
function commerce_paypal_ec_do_payment($payment_method, $order, $charge)

Replace:

'PAYMENTREQUEST_0_AMT' => commerce_paypal_price_amount($amount, $currency_code)

with

'PAYMENTREQUEST_0_AMT' => commerce_paypal_price_amount(commerce_currency_convert($order_total['amount'], $order_total['currency_code'], $currency_code), $currency_code)

to convert the Order total amount from local to the payment currency used by PayPal

It's not fixed unless it's committed to the project. Marking back as active. Thanks for your suggestion. If you could put your update in a patch that would help speed things along.

It does appear that the currency is converted already in commerce_paypal_ec_do_payment() as there is a call to alter the $amount before it is added to the $nvp array like so:

  // Convert the charge amount to the specified currency.
  $amount = commerce_currency_convert($charge['amount'], $charge['currency_code'], $currency_code);

So really this only needs to change in commerce_paypal_ec_set_express_checkout(). Patch attached.

There is also another problem when using currencies that are not supported and need to convert to dollars (or default currency).

I will demonstrate it with picture. So when buying more products, like 2x of one and 2x of another. There is a high chance the conversion will be wrong by one decimal at least. For example, you can see my picture, and see that PAYMENTREQUEST_0_AMT equals PAYMENTREQUEST_0_ITEMAMT but if you count the total of line items in
L_PAYMENTREQUEST_0_NUMBER_$i it will be 387,7. Which will break the payment as PP checks the sum of totals of line items and you will get the

"REDIRECT TO PAYPAL EXPRESS CHECKOUT FAILED. PLEASE TRY AGAIN OR CONTACT AN ADMINISTRATOR TO RESOLVE THE ISSUE."

With

PayPal server response:
Array
(
    [TIMESTAMP] => 2016-05-13T09:26:26Z
    [CORRELATIONID] => b9d2d051626a3
    [ACK] => Failure
    [VERSION] => 76.0
    [BUILD] => 000000
    [L_ERRORCODE0] => 10413
    [L_SHORTMESSAGE0] => Transaction refused because of an invalid argument. See additional error messages for details.
    [L_LONGMESSAGE0] => The totals of the cart item amounts do not match order amounts.
    [L_SEVERITYCODE0] => Error
)

I made a patch that will fix above issue, which normalizes total amount according to line items total if totals miss-match.

Marko, patch seems to be working however if there is a shipping line item its not being converted. It just gets a changed currency symbol.

Ok I made new patch, this one solves Shipping also, but also there were few problems with old one.

Please needs review. this is also a critical thing for, well most of the world :)

Patch #7 have solved the issue for me. Thanks.

#7 works! thank u Marko!

Hi everybody,
patch#7 works! thank you Marko!

Sounds like it's RTBC?

1. +++ b/modules/ec/commerce_paypal_ec.module
   @@ -1257,15 +1257,15 @@ function commerce_paypal_ec_do_payment($payment_method, $order, $charge) {
   -function commerce_paypal_ec_itemize_order($order, $currency_code) {
   -  $nvp = array();
   +function commerce_paypal_ec_itemize_order($order, $currency_code, $nvp) {
   

   This is a breaking change. NVP needs to default to an empty array

2. +++ b/modules/ec/commerce_paypal_ec.module
   @@ -1257,15 +1257,15 @@ function commerce_paypal_ec_do_payment($payment_method, $order, $charge) {
   +  $amt = 0;
   

   $amt is no longer used

Here is a new version of the patch, which has only has the logic in commerce_paypal_ec_itemize_order updated for better math and currency conversion handled. Along with the ensured currency conversion in PAYMENTREQUEST_0_AMT.

This needs manual testing in order to commit. INR is now supported by PayPal, so a different currency will have to be tested.

Hello,

This patch is not working with commerce_paypal 7.x-2.6 and 7..x-2.7. This patch is also not inclued/fixed in the updated version.

Best Regards,

Updated mglaman's patch from #13 to work on latest dev