Since a upgrade TVI (beta 3 -> beta 4), I see this notice :

"Notice : Undefined index: term_node_tid_depth dans tvi_render_view() (ligne 205 dans /MYWEBSITE.COM/sites/all/modules/tvi/tvi.module)."

A bug ?

CommentFileSizeAuthor
#30 tvi-php_error_undefined-2123659-30.patch1.36 KBmaijs
#26 interdiff.txt655 bytesNikolay Shapovalov
#26 tvi-php_error_undefined-2123659-26.patch1.36 KBNikolay Shapovalov
#4 tvi-undefined_index_term_node_tid_depth-2123659-4.patch1.35 KBopi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

skkonstantin’s picture

skkonstantin CreditAttribution: skkonstantin commented

+1

deviousway’s picture

deviousway CreditAttribution: deviousway commented

+1

vstmusic’s picture

vstmusic CreditAttribution: vstmusic commented

I replaced line 205 and 210 of the tvi.module file :

205: $block = $view->execute_display($display, array($tid));
210: return $view->execute_display($display, array($tid));

And It works…

It's perhaps not a clean method...

opi’s picture

opi
Primary language French
CreditAttribution: opi commented
Issue summary: View changes
Status: Active » Needs review
FileSize
tvi-undefined_index_term_node_tid_depth-2123659-4.patch1.35 KB

Quick (and dirty?) patch that works for me. Prevent looking for an unset variable.

Zekvyrin’s picture

Zekvyrin CreditAttribution: Zekvyrin commented

patch #4 works for me

albertguedes’s picture

albertguedes CreditAttribution: albertguedes commented

patch #4 works for me too

webel’s picture

webel CreditAttribution: webel commented

patch #4 works for me too, many thanks.

BTW this is a super little module. I have a site with extended Drupal7 accounts (replaced profiles), but taxonomy term links don't work against non-node entities. With TVI I was able to redirect to user-based views, very handy.

Nikita Petrov’s picture

Nikita Petrov CreditAttribution: Nikita Petrov commented

patch #4 works for me too, thanks.

Nikita Petrov’s picture

Nikita Petrov CreditAttribution: Nikita Petrov commented
Status: Needs review » Reviewed & tested by the community
caw67’s picture

caw67 CreditAttribution: caw67 commented

works for me! please apply the patch to dev version

firesidelibrarian’s picture

firesidelibrarian CreditAttribution: firesidelibrarian commented

Patch works for me too, and I agree with 'webel' that this is a "super little module"!

richardcanoe’s picture

richardcanoe CreditAttribution: richardcanoe commented

patch #4 works for me too, thanks.

deggertsen’s picture

deggertsen CreditAttribution: deggertsen commented

#4 works. Thanks.

Jochen Wendebaum’s picture

Jochen Wendebaum CreditAttribution: Jochen Wendebaum commented

Yes, this works. I would like to see the module updated after those passed 4 months...

danharper’s picture

danharper CreditAttribution: danharper commented

#4 tested and works fine for me.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea commented

The patch is doing the job. You can kick it in.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented
Assigned: Unassigned » kevinquillen
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Yes, #3 may not be super clean, but it worked for me, too! Thanks!

katannshaw’s picture

katannshaw CreditAttribution: katannshaw commented

Great patch @ #4 for a great module. Thanks.

Josias’s picture

Josias CreditAttribution: Josias commented

#4 Works for me, great patch, Thanks!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

patch #4 works for me as well, Thanks

goodboy’s picture

goodboy
Location Kharkiv, Ukraine
CreditAttribution: goodboy commented

The error occurs because not defined $view->display_handler->display->display_options["arguments"]["term_node_tid_depth"]["depth"] and patch#4 fix it, great. But, if you add argument term_node_tid_depth to default view display and set default arguments to the page display - no error occurs and no need to patch. So variable $view->display_handler->display->display_options["arguments"]["term_node_tid_depth"]["depth"] is argument for default display of the view.

Nikolay Shapovalov’s picture

Nikolay Shapovalov
Primary language Russian
CreditAttribution: Nikolay Shapovalov commented

But, if you add argument term_node_tid_depth to default view display and set default arguments to the page display - no error occurs and no need to patch.

But when you use another argument the error occurs. So the pacth #4 is required. And it works for me.

kevinquillen’s picture

kevinquillen CreditAttribution: kevinquillen commented

I shall review this and other TVI patches this week before heading to Drupalcon.

Sorry, issues on modules where I am not a project owner elude me in my Drupal dashboard so I fell behind.

goodboy’s picture

goodboy
Location Kharkiv, Ukraine
CreditAttribution: goodboy commented

But when you use another argument the error occurs. So the pacth #4 is required. And it works for me.

Nikolay, I just tell why this error occurs and how to avoid this. The patch works for me too, but I don't want patch it every time or install patched module. So, I don't use this patch and haven't error, and I can update this module using "Update manager".

Nikolay Shapovalov’s picture

Nikolay Shapovalov
Primary language Russian
CreditAttribution: Nikolay Shapovalov commented
Status: Reviewed & tested by the community » Needs review
FileSize
tvi-php_error_undefined-2123659-26.patch1.36 KB
interdiff.txt655 bytes

This is same as patch #4, but with a small improve

Nikolay Shapovalov’s picture

Nikolay Shapovalov
Primary language Russian
CreditAttribution: Nikolay Shapovalov commented
Status: Needs review » Needs work

Why does we use $view->display_handler->display->display_options["arguments"]["term_node_tid_depth"]["depth"]?
In this case depth modifier is hard-coded, and can't be modified.

And why in tvi_render_view() uses two variables, which not use in this function $depth, $op?

Nikolay Shapovalov’s picture

Nikolay Shapovalov
Primary language Russian
CreditAttribution: Nikolay Shapovalov commented
Related issues: +#2294655: Pass all arguments to views
cirrus3d’s picture

cirrus3d CreditAttribution: cirrus3d commented

Could we add an option in the module so we can have or not have depth if we want it to?
For example I'm using faceted filters and the indexed views don't support depth, so I get this notice.

maijs’s picture

maijs CreditAttribution: maijs commented
FileSize
tvi-php_error_undefined-2123659-30.patch1.36 KB

Re-roll of the patch in #26 to have it in line with latest codebase (commit 4e04876).

jasom’s picture

jasom CreditAttribution: jasom commented

#30 Error disappeared.

andriyun’s picture

andriyun CreditAttribution: andriyun commented

This patch #30 work, maybe, for dev branch module.

+++ b/tvi.module
+++ b/tvi.module
@@ -202,16 +202,23 @@ function tvi_render_view($tid = '', $depth = 0, $op = 'page') {

This code from patch https://www.drupal.org/files/issues/tvi-metatags-1931836-8.patch which included in dev-branch for module

You need manually apply changes for stable branch and post correct patch

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr commented
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
Assigned: kevinquillen » Unassigned
Status: Needs work » Fixed

Thank you guys.

  • DuaelFr committed d1c3c86 on 7.x-1.x authored by opi 
    Issue #2123659 by zniki.ru, maijs, opi | vstmusic: Fixed php error:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.