i saw this: https://drupal.org/node/833066
and i realize that you can also (i think) touch feeds_process_limit
...but why not simply expose this setting on the feeds admin via the UI? should people really be mucking about in the settings file just to do something like:
a) limit total number of items per import (all feeds)
b) limit total number of items imported by one feed item (maybe this is exposed alongside the Link field when creating a feed?)
just my own opinion, but i'd love to see it as a feature! "Limit per batch" (all feed items) or "Allow to Limit by Feed Item" and then expose the setting in the individual feed items like "don't download more than (Dropdown) items"
Comment | File | Size | Author |
---|---|---|---|
#6 | feeds-expose_process_limit-2124281-6.patch | 3.84 KB | ufku |
#3 | feeds-expose_process_limit-2124281-3.patch | 3.97 KB | ufku |
#1 | feeds-expose_process_limit-2124281-1.patch | 1.26 KB | ufku |
Comments
Comment #1
ufku CreditAttribution: ufku commentedThe patch exposes the limit in Processor settings. The default value is still
variable_get('feeds_process_limit', FEEDS_PROCESS_LIMIT)
Comment #3
ufku CreditAttribution: ufku commentedFixed FeedsEntityProcessor::configDefaults() and updated tests to use the exposed limit.
Comment #4
ufku CreditAttribution: ufku commentedComment #6
ufku CreditAttribution: ufku commentedIt seems FeedsEntityProcessor::configDefaults() should not call parent::configDefaults()
Comment #7
MegaChriz CreditAttribution: MegaChriz commented@ufku
FeedsEntityProcessor::configDefaults()
can not callparent::configDefaults()
, becauseFeedsProcessor::configDefaults()
calls::bundle()
and the FeedsEntityProcessor's implementation of thebundle()
method needs to know the importer's config in order to determine the bundle, so calling the parent'sconfigDefaults()
method would trigger an infinite loop:Comment #8
anouSorry to tell you this but patch from #6 doesn't work anymore... I'm also trying to solve this feature request.
Now
FeedsEntityProcessor.inc
has been removed from Feeds module and is a stand alone module : Feeds entity processorComment #9
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedYes, the patch from #6 needs a reroll. More specifically, the following line should be removed from the patch:
Also note that some parsers ignore this setting.
And the patch will only have effect on the CSV parser. Parsers provided by contrib modules will continue to use "feeds_process_limit" setting (or ignore the setting at all, as already said). As such, I think the setting should be moved to the CSV parser.Comment #10
MegaChriz CreditAttribution: MegaChriz as a volunteer commentedOops, spoke to soon, I saw a comment in the patch mentioning the CSV parser, but it wasn't actually in the CSV parser.
That means the patch will need a reroll, but the description of the setting should also say that some parsers will ignore it.
Comment #11
sbydrupal CreditAttribution: sbydrupal commentedCan you please comment on #10 at https://www.drupal.org/node/1909974 whether it is possible to
solve ? I don't want to replicate same comment in this thread. Thanks