I'm having a couple different problems with email notifications settings. Running commons3.3

-

  1. The wording of the flags on the notification-settings page seems confusing. The page displays "Don't receive email updates", which I and users took to mean that email notifications were disabled, when in fact they are enabled and emails are sent. So I was thinking the value of the flag had gotten reversed somewhere. But as I write this, I have just now realized that is not the case but what is being displayed is the text indicating the option to change the flag, rather than the current value of the flag. This is pretty confusing. I think most people looking at a list such as this expect to be told what their current settings are, not what they can change their settings to if they click.
    I don't know if a good solution is to change the text the flag displays (which then would kind of reverse the logic of the flag?) or to change the format to display first the current value and then a link with the option to flip it, or some variation.
  2. - the pager on the notification-settings page is broken. My example case: i have more than 20 "groups i follow" and more than 20 "Other content I follow". I view the "groups I follow tab" and i click the pager >> next page link and instead of seeing more groups I get taken to page 2 of "other content" and then the "groups" tab gets populated with "other content" and I have to reload the page in order to access groups again.
  3. - sometimes some groups show up twice in a row on the "groups I follow" list. I'm not sure why or when it happens sometimes and not others and with some groups and not others. The most common case is that a group will be repeated on the list if the flag also shows "Don't receive email updates" and will not be repeated if the flag is opposite, but this is not always the case. Flipping the flag and reloading the page will sometimes correct things and only show the group 1 time, but then sometimes the copy comes back when the page is reloaded later on. So far I have only paid attention to the "groups i follow" list, no sure if this also happens on other tabs as well. The total number of groups noted in the tab title is correct and is not counting the repeats.

    screenshot shows some groups repeated on list
    One effect of this is that if a group is repeated and on one instance I flip the flag, until I reload the page it shows two different and opposite flags for the same group.

    screenshot show the same group with both/opposite flag settings

  4. - as an admin user of the site, I cannot figure out how to control/turn off email notifications. I seem to get a copy of every notification that is sent out, regardless of my settings on the notification-settings page, regardless of if I follow the group/content or not, etc. As far as I can tell, I am receiving notifications for all activity. I have not debugged this too much deeper to see if there are situations when the admin do not receive notifications, but in general it seems like all of them. and definitely the email settings or follow settings have no effect.

EDIT put items into numbered list rather than bulleted.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ezra-g’s picture

Issue tags: +commons 7.x-3.5 radar

Thanks for this report. Adding to our Commons 3.5 triage radar.

japerry’s picture

Category: Bug report » Support request
Status: Active » Postponed (maintainer needs more info)
FileSize
102.91 KB

Hi! Thanks for your report!

However, I think we need a little more information. Your screenshot isn't really matching up to what stock commons offers out of the box. Are your features all setup to not be overridden? There is a possibility that customizations are causing an issue.

It should look similar to this. (/user/(userid)/notification-settings):

If you're fairly certain that its a stock version of commons, it'd be great to get a screencast or a step by step reproduction from install.

WebSinPat’s picture

@japerry, wow yeah that does look quite different! I am not sure how I managed to get something so unique... I am running DC 3.3, which I upgraded from 3.2. During the upgrade I ran into a number of features that would not revert, as I captured in #2086905: Update Commons Features for cosmetic/syntactic changes, but I was given to believe those features were unlikely to cause functional problems. Also I am using a sky-based theme rather than the commons theme.
Is this a theming issue (at least as far the difference of checkboxes versus flag link text)?

I will look into it some more and see what I can nail down.

mpaler’s picture

@japerry - Those checkboxes for the for the "Send Email" flag. Is that out of the box on Commons 3.5?

ezra-g’s picture

@mpaler Yes.

mpaler’s picture

Hmmm. Curious to know how/where in the codebase/configuration that is handled. I just did a fresh upgrade to 3.5 and reverted all. I'm still seeing the text based flag links.

Not sure if this is related, but I do, however, still have a few features that won't revert. Similar to #2086905: Update Commons Features for cosmetic/syntactic changes

WebSinPat’s picture

Issue summary: View changes
WebSinPat’s picture

ok, so i think the status of these issues is as follows
1) FIXED. confusing email flag text has been replaced with checkboxes since DC3.3. If anyone @mpaler knows where this code is or a patch for just this change, I'd be interested in it, but meantime I have changed the text I display to be less confusing (I think). I'll attach a screenshot if anyone else on 3.3 can use it.

2) does anyone get the pager to work? Is this a config issue on my end?

3) FIXED. this was my config error, when I modified the views to address #1920824: Admin viewing another user's notification settings tab shows admin's notification settings, I didnt configure 'unique' into the sql query. This has now been addressed with the patches and commits over there.

4) Email notifications can't be turned on/off does not have to do with being an admin user as I describe in my OP, but with having more than one email notification flag set and I think is a bug in message_subscribe_email #2126689: Email Notifications sent regardless of email checkboxes, revisited. bug in message_subscribe_email

So it seems like potentially the pager issue #2 might be the only issue that is still outstanding for commons. And #4 for message_subscribe.

Here is the screenshot of how my email flag text looks now. the text tells a user what will happen if they click on the link/flag.
instead of "send email" flag text now reads "subscribe to emails"

japerry’s picture

#8 - 1, the checkboxes are in commons_origins.js, the first code snippet there:

  var set_follow_checkboxes = function(){
    $('#quicktabs-commons_follow_ui .flag-email-group a, #quicktabs-commons_follow_ui .flag-email-node a, #quicktabs-commons_follow_ui .flag-email-user a, #quicktabs-commons_follow_ui .flag-email-term a').each(function(){
      var a_target = $(this).addClass('formatted-as-checkbox').removeClass('action-item-small action-item-small-active');

      if (a_target.children('span').length === 0) {
        a_target.wrapInner('<span></span>');
      }

      if (a_target.hasClass('flag-action') && a_target.children('input').length === 0) {
        a_target.prepend('<input type="checkbox">');
      } else if (a_target.children('input').length === 0) {
        a_target.prepend('<input type="checkbox" checked>');
      }
    });
  };
WebSinPat’s picture

Status: Postponed (maintainer needs more info) » Active

For #2 regarding the pager, I think the problem comes that the same view (commons_follow_node) is being used for both the follow_group and follow_node tabs, so they both get the same pager ID.
I'm not sure how to address this.

lsolesen’s picture

Issue tags: -commons 7.x-3.5 radar +issue-triage
lsolesen’s picture

Issue tags: -issue-triage +Novice