Happens when user clicks next button after files have been uploaded but before dialog closes. Watchdog reports errors like
File temporary://p188iri2p31u1n1e7m1ffi1437ie38.tmp (/tmp/p188iri2p31u1n1e7m1ffi1437ie38.tmp) could not be copied because it does not exist.

CommentFileSizeAuthor
#3 plupload-2127681-3-disable-submit-button-js.patch612 bytesmikeytown2
#1 plupload-2127681-1-disable-submit-button-js.patch568 bytesmikeytown2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
plupload-2127681-1-disable-submit-button-js.patch568 bytes

Not Patched Video: http://www.youtube.com/watch?v=CFXPN9degVU

Patched Video: http://www.youtube.com/watch?v=CQ8tQkBW_Io

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
Status: Active » Needs review
mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented
FileSize
plupload-2127681-3-disable-submit-button-js.patch612 bytes

Opps old patch; here is the correct one

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Project: Plupload integration » File Entity (fieldable files)
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Needs work

This looks like File entity related issue.... We cannot add File entity-specific JS to Plupload module.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Project: File Entity (fieldable files) » Plupload integration
Status: Needs work » Needs review

This specific input button is provided by plupload, so yes, it is Plupload's responsibility.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 7.x-2.x-dev » 7.x-1.x-dev
slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented
Project: Plupload integration » File Entity (fieldable files)
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Needs work

@Dave Reid: Plupload provides no buttons. It is simply a form element that is used in a form, which is provided by File entity (in this specific case).

Prove:

➜  plupload git:(7.x-1.x) ✗ grep -i -R 'next' ./
➜  plupload git:(7.x-1.x) ✗
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Project: File Entity (fieldable files) » Plupload integration
Version: 7.x-2.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review

I'm guessing it's the plupload *library* that adds the button. There is no button called 'Saving...' added by File entity.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Project: Plupload integration » File Entity (fieldable files)
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Needs review » Needs work

Grr, I misread the patch as looking for an input element named 'Saving...' which is not the case. Apologies.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

How does this work with the multiple-step upload workflow if the multiform module is enabled? We will still need a way to hit Next and load the next form.

slashrsm’s picture

slashrsm CreditAttribution: slashrsm commented

Once thing that comes to my mind is #submit_element option, which we provide. It is very useful when you have more buttons on a form and you want to associate one of them with Plupload.

Plupload module will disable this button while uploading AFAIK, which might fix this problem.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Any progress on this?

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

@mikeytown2 - Are you using plupload + multiform + media + file_entity?

You can try the patch in #2142375: Fatal error when adding 2 pdfs at file/add with media, multiform, and plupload
If your uploads fail for some reason like the fatal error in the issue above, it will show one file as temporary.

and

#2128253-3: File multiple upload does not respect the field's configuration 'File directory'

I noticed if the file directories that the files are going to be uploaded to aren't created first then you can get those temporary files. Try manually creating the directories and then try the uploads again. If you don't get any errors any more, then you need the patch from #2128253-3: File multiple upload does not respect the field's configuration 'File directory'.

These may not be related, but if they are I hope that helps.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

@gmclelland
No fatal errors, but I am using plupload + multiform + media + file_entity. Check the repo video in #1. Still using this patch #1946298: upload_location directory not being created if it doesn't exist for Plupload so destination directories are being created. Also still using the patch in #3 to fix this issue.

gmclelland’s picture

gmclelland CreditAttribution: gmclelland commented

Hmm... So it looks like you are using https://drupal.org/sandbox/fangel/1652676 + plupload + multiform + media + file_entity?

FYI...The patch for File Entity in #2128253-3: File multiple upload does not respect the field's configuration 'File directory' would replace the patch for Plupload in https://drupal.org/node/2127681#comment-8144255

Also, I believe the patch for Plupload in https://drupal.org/node/2127681#comment-8144255 no longer applies to the latest plupload module release.

mikeytown2’s picture

mikeytown2 CreditAttribution: mikeytown2 commented

Yep, we are using the sandbox as well.