Set the active class with JS [#2131731]

Problem/Motivation

The active menu item is not highlighted because the markup of the menu tree is cached.
The cached markup incorrectly stores the "active" classes if the current page is different than the cached one.

Proposed resolution

Set the active classes using JS.

Remaining tasks

Use CSS to highlight the new classes.

#1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links

Comment	File	Size	Author
#1	admin_menu-js-active-class-2131731-1.patch	909 bytes	Sweetchuck
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Sweetchuck

Hungarian

Budapest

CreditAttribution: Sweetchuck commented 8 November 2013 at 18:05

File	Size
admin_menu-js-active-class-2131731-1.patch	909 bytes

Comment #2

Sweetchuck

Hungarian

Budapest

CreditAttribution: Sweetchuck commented 8 November 2013 at 22:58

Status:

Active

» Needs review

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

Comment #4

truls1502

he/him

Norwegian Bokmål

CreditAttribution: truls1502 as a volunteer and at SignWo AS commented 2 November 2018 at 21:18

Status:	Postponed (maintainer needs more info)	» Closed (cannot reproduce)
Issue tags:	-postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)