maybe this is user error, i've had a fair amount of trouble with the installation process. but trying to run coder_upgrade in a Drupal 7.x installation on a copy of a custom 6.x module, the only changes it makes are style changes - whitespace adjustments, breaking up array definitions into multiple lines, etc. there are no actual changes in either the files under the "new/" directory or in the patch file (not sure the difference between these, if any) that relate to Drupal 7.x API changes. isn't that supposed to be the point?

Comments

solotandem’s picture

solotandem CreditAttribution: solotandem commented

What core API routines does the 6.x module implement? Coder Upgrade does not have routines for all core API routines. The code cleanup (whitespace, etc.) is a natural byproduct of the file being parsed and rewritten by the Grammar Parser.

brad.bulger’s picture

brad.bulger CreditAttribution: brad.bulger commented

hook_nodeapi() for instance. or the use of update_sql() in install files - which the coder review (vs upgrade) did flag.

is PHP_CodeSniffer required for catching API changes? i was not able to get that set up. also, i'm using PHP 5.2, so i had to use the patch from #1880186: Parse error: syntax error, unexpected T_FUNCTION in coder_review.admin.inc on line 61 (PHP 5.3 required for closures) #13

solotandem’s picture

solotandem CreditAttribution: solotandem commented

The hook_nodeapi() should be updated. Have you tried the upgrade site? It avoids the code sniffer issues you refer to.

Coder Upgrade does not depend on Coder Review; the latter uses code sniffer.

brad.bulger’s picture

brad.bulger CreditAttribution: brad.bulger commented

thanks, i'll try that. i also got further using the command-line patch from #780034: coder-upgrade drush command. i hadn't seen any permission errors in the browser, but maybe they were happening and being suppressed by my site's configuration somewhow.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Active » Closed (won't fix)

Coder 7.x is frozen now and will not receive updates. Coder 8.x-2.x can be used to check code for any Drupal version, Coder 8.x-2.x also supports the phpcbf command to automatically fix conding standard errors. Please check if this issue is still relevant and reopen against that version if necessary.