Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.After update to current dev there is a watchdog message (taken from drush):
WD ctools: Plugin iCal parser of plugin type feeds:plugins points to nonexistent file sites/all/modules/date_ical/includes/DateiCalFeedsParser.inc for class handler handler.
It turns out the file has this name but in other case.
Was this developed on windoze? On linuxes file case matters.
Setting prio high as this makes the plugin nonfunctional.
Comments
Comment #1
geek-merlinPatch flying in.
Renamed all class and plugin names to proper camelcase Foo IcalBar.
Did not touch other occurences of fooiCalBar although this might be a good idea.
Comment #2
coredumperror CreditAttribution: coredumperror commentedI found the underlying problem. date_ical.info specifies the parser file using the wrong capitalization, and I didn't notice because I develop on OSX (which uses a rare example of a unix filesystem with case insensitivity). I've attached a patch that should fix this problem. Please let me know if it works for you.
Comment #3
geek-merlinWOW, quick response!
Actually it's a bit more messed up than this because everything carries the "wrong" camelcase "DateiCalFeedsParser", but the file has the "right" one: DateIcalFeedsParser.inc
If you prefer to carry on the "wrong" case, you also have to change the filename.
See my patch for the opposite approach.
Comment #4
geek-merlinUpdated patch flying in (your #2 + rename file). Choose one.
Comment #5
coredumperror CreditAttribution: coredumperror commentedI intentionally named the file with the lowercase "i", because it's lowercase in in the name of the spec: "iCalendar". It felt wrong to intentionally mis-capitalize the name just to more strictly follow an arbitrary naming convention. It ends up being camelcase anyway, just with the capitalization moved one letter to the right.
However, now that I've looked closely at the files in the dev release archive, I notice that the file is actually named wrong. Apparently, OSX's case-insensitive filesystem made it so git didn't notice that I renamed the old file to use the new lowercase "i" capitalization scheme. I had to log into a linux system, clone the repo, rename the file, and push the change up from there to get git to notice it.
This change won't appear in the dev release for a while, but if you clone date_ical 3.x from git (git clone --branch 7.x-3.x http://git.drupal.org/project/date_ical.git), you'll get the fixed filename.
Thank you so much for pointing this out. I never would have even realized there was a problem.
Comment #6
geek-merlinThank you robert for this great module and your quick responses.
It's really great to cooperate like this.
If you want to thank future patch authors you may want to attribute their patches.
No problem for me, my commit history is long, but if people contribute their fisrst patch they might be pleased if you do and maybe be pissed if you don't.
All the best!
axel
Comment #7
coredumperror CreditAttribution: coredumperror commentedHuh, I was not aware of the "commit author" feature on git. I'll definitely keep that in mind in the future.
As it happens, though, I didn't actually use either of your patches. I discovered the naming problem in the git repo and made the fix (as I described in my previous comment) before you posted your own (identical) patch.
However, I referenced this issue in the commit messages for this bug. If anyone goes to this page (which will I will link in 3.0's patch notes when I make it an official release), they'll see that all the credit clearly belongs to you. I would not have known this critical bug even existed without your input.