Add fake_buttons_alter() [#2133567]

Can we add a hook_media_browser_fake_buttons_alter()?

I have an issue getting my Sticky Edit Actions module to work correctly since Media plugins currently don't use real forms in the media browser. Attached is a patch to add an alter that allows me to add a class to the buttons to get things working correctly.

There is an open issue to use real forms for plugins at #1558042: Refactor Views plugin code as a form rather than raw html and would make this issue moot as things would 'just work' then.

Comment	File	Size	Author
#3	media-fake-button-alter-1558042-03.patch	1.26 KB	Elijah Lynn
#3
#1	media-fake-button-alter-1558042-01.patch	486 bytes	Elijah Lynn
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Elijah Lynn

Portland, Oregon

CreditAttribution: Elijah Lynn commented 11 November 2013 at 21:41

Status:

Active

» Needs review

File	Size
media-fake-button-alter-1558042-01.patch	486 bytes

Adding patch.

Comment #2

deviantintegral CreditAttribution: deviantintegral commented 25 March 2014 at 20:28

Patch is good, but we're missing docs in media.api.php.

Comment #3

Elijah Lynn

Portland, Oregon

CreditAttribution: Elijah Lynn commented 16 May 2014 at 20:19

File	Size
media-fake-button-alter-1558042-03.patch	1.26 KB

Thanks Andrew!

Here is some docs ripped from the related Sticky Edit Actions patch.

Comment #4

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 23 January 2019 at 23:36

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

The 5 year old patch in #3 to media.api.php does not apply to the latest media 7.x-2.x-dev and if still relevant needs to be rerolled.

Checking patch includes/media.browser.inc...
Hunk #1 succeeded at 99 (offset 11 lines).
Checking patch media.api.php...
error: while searching for:
  $stored_params['types'][] = 'document';
  unset($stored_params['enabledPlugins'][0]);
}

error: patch failed: media.api.php:102
error: media.api.php: patch does not apply