blank lines / newlines are stripped out of php code in docs

I noticed this too.

Line 1

Line 3

Line 5
Line 6

Was rather annoying to me.

Isn't this probably a Core bug with the text filter, rather than a Drupal.org-specific issue? Or maybe it's the order of text filters in the d.o "Filtered HTML" text format?

I think we'd have found it if it before was a core bug. Mind you the order of the filters is quite likely...

Code Filter module removes leading and trailing line breaks. I think we should remove this functionality and let user decide to remove or leave line breaks.

RE #5 - the problem here is not the first/last newlines being stripped out. It is that blank lines in the middle of code blocks are stripped out.

Yeah. We have a real problem. Code Filter removes blank lines in order to avoid clashes with line break filter which converts them to html tags...

The filter 'Convert line breaks into HTML' needs to come after 'Code filter' to fix this issue.

@dokumori I tested it with your solution but it didn't fix the problem. The blank line between other lines was removed. I tied it here: https://kalman-drupal.redesign.devdrupal.org/node/2234363/

The cleanest way I found to make this happen is to add extra markup.

After reading the drupal core filter which does the replacement of new lines(see _filter_autop()), which is causing the problem, I also see that it is skipping the pre tag contents.
That makes sense, so if we wrap the return text with the pre tag, drupal core will not try to replace newlines inside.
That's actually what pre(formatted) tag means, so it sounds consistent.

In the drupal.org specific case:

• We need to re-arrange the order as dokumori mentions, which is also added on the module's readme.
• It sounds like a good opportunity to update the module code. This patch is against 7.x-1.x branch, which is several commits ahead of 1.0, which AFAIK is used on d.o

Fixing text in the test to match new output, also includes a new line there so this behavior is tested too(maybe we need to add one more when core filter is also there).

Tag and testing instructions.

I think the same change should be made in codefilter_process_code() for blocks like in comment #2.

I think it is looking ok without an additional change in codefilter_process_code():

Setting to fixed - let me know if there is more to do here.

Not sure why #17 performed a manual test instead of adding an automated test...?

Re-rolled against HEAD.

This follow-up patch just adds an automated test for the manual test performed in #17.

This actually got commited, with the wrong commit message. Thanks sun!

The cumulative change needs to be forward-ported to D8.