Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We should replace the if (marker.html)
with if (typeof marker.html !== 'undefined')
so that it can exists but has no value. This is necessary if you want to style that via an element class.
Comment | File | Size | Author |
---|---|---|---|
#5 | leaflet-dont-check-whether-marker-html-is-empty-2135061-5.patch | 412 bytes | milesw |
Comments
Comment #1
yannickooComment #2
yannickooComment #3
derhasi CreditAttribution: derhasi commentedWe should not only check that, but implement icon and divIcon in maintainable way. The current code is working with a lot assumptions and little encapsulated code.
Comment #4
derhasi CreditAttribution: derhasi commentedIn #2178231: Error then use icon from related taxonony term field I posted a patch with a little bit more changes, that will deal better with divIcon.
Comment #5
milesw CreditAttribution: milesw commentedThanks for fixing this, yannickoo.
Updated the patch so it applies to dev.
This is trivial fix and should be committed.