Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Most of these should fail as per my manual testing. All of these would have passed before. Now with the new routes I think it is debatable whether the add/edit/delete pages should have the tabs on them (they do have other tabs on the same level though), or not. But at least the edit page always should have the translate tab (and the translate page itself obviously).
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | interdiff.2135101.13.17.txt | 1.92 KB | YesCT |
| #17 | core-tab-problems-2135101_17.patch | 1.98 KB | stefank |
| #13 | core-tab-problems-2135101_13.patch | 1.97 KB | stefank |
| #6 | interdiff.txt | 578 bytes | Gábor Hojtsy |
| #6 | core-tab-problems.patch | 1.97 KB | Gábor Hojtsy |
Comments
Comment #1
Gábor HojtsyComment #2
YesCT CreditAttribution: YesCT commentedComment #4
Gábor HojtsySo this is basically due to core being dumb again :D Eg. if you apply this patch most of the contact related ones will pass. The add/edit pages don't have the tabs anymore, but that is due to them being a separate route / path now, and it would be non-standard (impossible?) for the tabs to show up on them. They are on one level deeper vs. where the tabs show. So they'll have the breadcrumbs but not the tabs. The tests for those should go away from the patch, which combined with this core one would make it all pass.
Comment #6
Gábor HojtsyWell, there are still two fails even with the core patch but that is due to missing permissions in the test.
Comment #8
YesCT CreditAttribution: YesCT commentedcore issue (not a blocker for this) #2135787: Move static config entity local tasks to local_tasks.yml
Comment #9
Gábor HojtsySo what we can do here is we get these two issues fixed in core:
- #2135787: Move static config entity local tasks to local_tasks.yml
- #2111823: Convert field_ui / Entity local tasks to YAML definitions
Those would provide the tabs in the *current* tab system instead of the *old* tab system, so we can extend them. Unless those are fixed, the tabs themselves will only work on some config entities.
Comment #10
Gábor HojtsyWill need a reroll against core now, however still postponed on the other two patches.
Comment #11
Gábor HojtsyFully qualify which translation tabs.
Comment #12
mgiffordComment #13
stefank CreditAttribution: stefank commentedAs the two issues seems to be fixed, rerolling the patch from #6.
Comment #14
stefank CreditAttribution: stefank commentedTriggering testbot.
Comment #16
YesCT CreditAttribution: YesCT commented@stefank can you verify manually that the translate tabs are missing on those pages? (or maybe they are named differently?)
Comment #17
stefank CreditAttribution: stefank commented@YesCT The translate tab is there, but the name changed to "Translate contact form", also the settings changed to "account settings". Hopefully that should pass now (it does pass locally).
Thanks for pointing it out.
Comment #18
YesCT CreditAttribution: YesCT commentedto see what that change looked like, I made an interdiff.
For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff
Comment #19
tstoecklerAwesome, thanks!
Comment #20
Gábor HojtsyComment #21
alexpottThis issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed c7dca6d and pushed to 8.0.x. Thanks!