Trying to get property of non-object in flag_entity->applies_to_content_object() [#2135865]

upon upgrading to ogx2, which uses entity references, get these errors when view the panels layout, e.g. /admin/structure/pages/nojs/operation/node_view/handlers/node_view_panel_context/content

Notice: Trying to get property of non-object in flag_entity->applies_to_content_object() (line 1391 of /www/www-staging/drupal.sandbox.sanger.ac.uk/htdocs/sites/all/modules/contrib/flag/flag.inc).

Comment	File	Size	Author
#11	flag-null_entity-2135865-11.patch	612 bytes	maximpodorov
#11

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

joachim CreditAttribution: joachim commented 15 November 2013 at 08:54

Version:	7.x-2.1	» 7.x-2.x-dev
Status:	Active	» Postponed (maintainer needs more info)

What's ogx2?

Can you debug to find out why Flag doesn't get what it's expecting there?

Comment #2

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:09

organic groups v2

Comment #3

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:16

tried this

  /**
   * Checks whether the flag applies for the current entity bundle.
   */
  function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    drupal_set_message('entity_info<pre>'.htmlspecialchars(print_r($entity_info,1)).'</pre>');
    drupal_set_message('entity<pre>'.htmlspecialchars(print_r($entity,1)).'</pre>');
    drupal_set_message('this<pre>'.htmlspecialchars(print_r($this,1)).'</pre>');

and got

Comment #4

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:19

the new organic groups uses the project entityreference?

Comment #5

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:26

the this:

  function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    drupal_set_message('entity_info entity keys bundle='.$entity_info['entity keys']['bundle']);
    drupal_set_message('this types=<pre>'.print_r($this->types,1).'</pre>');
    drupal_set_message('entity_info entity keys bundle='.$entity_info['entity keys']['bundle']);
    drupal_set_message('entity entity_info entity keys bundle='.$entity->{$entity_info['entity keys']['bundle']});

and got

entity_info entity keys bundle=type
this types=
Array
(
    [0] => book
    [1] => group
    [2] => forum
    [3] => forum_general_topic
    [4] => domain_book
    [5] => corporate_news
    [6] => campus_event
    [7] => page
    [8] => service
    [9] => story
    [10] => webform
)
entity_info entity keys bundle=type
entity entity_info entity keys bundle=
entity_info entity keys bundle=type
this types=
Array
(
    [0] => book
    [1] => group
    [2] => forum
    [3] => forum_general_topic
    [4] => domain_book
    [5] => corporate_news
    [6] => chitchat
    [7] => campus_event
    [8] => noticeboard
    [9] => page
    [10] => service
)
entity_info entity keys bundle=type
entity entity_info entity keys bundle=

Comment #6

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:34

$entity appears to be null...

Comment #7

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:41

  function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    drupal_set_message('entity=<pre>'.print_r($entity,1).'</pre>');
    ......
  function applies_to_content_id($content_id) {
    drupal_set_message('applies_to_content_id<pre>'.print_r($this,1).'</pre>');
    drupal_set_message('this applies_to_content_object this fetch_content content_id='.$this->applies_to_content_object($this->fetch_content($content_id)));
    return $this->applies_to_content_object($this->fetch_content($content_id));
  }

and got

Comment #8

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:46

  function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    drupal_set_message('entity=<pre>'.print_r($entity,1).'</pre>');
    ......
  function applies_to_content_id($content_id) {
    drupal_set_message('content_id='.print_r($content_id,1));
    drupal_set_message('this fetch_content content_id ='.$this->fetch_content($content_id));

and got


content_id=structure
this fetch_content content_id =
entity=
content_id=structure
this fetch_content content_id =
entity=

Comment #9

StephenRobinson CreditAttribution: StephenRobinson commented 15 November 2013 at 11:54

this seems to fix it without any noticable side effects:

  /**
   * Checks whether the flag applies for the current entity bundle.
   */
  function applies_to_content_object($entity) {
    if(is_object($entity)){ // added
      $entity_info = entity_get_info($this->content_type);
      if (empty($entity_info['entity keys']['bundle']) || in_array($entity->{$entity_info['entity keys']['bundle']}, $this->types)) {
        return TRUE;
      }
    } // added
    return FALSE;
  }

Comment #10

joachim CreditAttribution: joachim commented 15 November 2013 at 12:05

$entity should not be NULL. Can you figure out who's calling that improperly?

BTW, very good debugging!
I recommend the use of devel module, as its dpr() and dpm() functions will save you a lot of typing :)

Comment #11

maximpodorov CreditAttribution: maximpodorov commented 25 December 2013 at 23:49

Status:

Postponed (maintainer needs more info)

» Needs review

File	Size
flag-null_entity-2135865-11.patch	612 bytes

It's Flag module who passes NULL object into entity hooks. This commit
http://drupalcode.org/project/flag.git/commitdiff/ed26347
unconditionally passes $flagging variable into entity_presave hooks. The patch fixes this.

Comment #12

25 December 2013 at 23:51

Status:

Needs review

» Needs work

The last submitted patch, 11: flag-null_entity-2135865-11.patch, failed testing.

Comment #13

maximpodorov CreditAttribution: maximpodorov commented 26 December 2013 at 06:23

Sorry, my patch was for 7.x-3.x version. Maybe it should go to e new issue.

Comment #14

joachim CreditAttribution: joachim commented 26 December 2013 at 09:55

I don't think your patch is related to this issue.

Comment #15

maximpodorov CreditAttribution: maximpodorov commented 26 December 2013 at 13:43

OK? I've created new issue: #2162925: Passing NULL to entity hooks.

Comment #16

joachim CreditAttribution: joachim commented 23 February 2014 at 08:44

#2162925: Passing NULL to entity hooks is now fixed, but it's unrelated to this issue because on 2.x flagging records are not entities.

Comment #17

hyside CreditAttribution: hyside commented 28 August 2014 at 20:12

I was also running into this issue, attempting to view flagged content of all types in a custom view whenever a user attempted to view that page with no content actually flagged yet. The issue was in flag.inc around line 1391, trying to read a non-object when there were no flagged items, so I added a validity check on $entity prior to attempting to read it.

Moving from this:

function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    if (empty($entity_info['entity keys']['bundle']) || in_array($entity->{$entity_info['entity keys']['bundle']}, $this->types)) {
      return TRUE;
    }
    return FALSE;
  }

To this:

  function applies_to_content_object($entity) {
    $entity_info = entity_get_info($this->content_type);
    if (empty($entity_info['entity keys']['bundle'])) {
      return TRUE;
    }
    else if ($entity) {
        if (in_array($entity->{$entity_info['entity keys']['bundle']}, $this->types)) {
            return TRUE;
        }
    }
    return FALSE;
  }

Comment #18

joachim CreditAttribution: joachim commented 28 August 2014 at 22:31

> I was also running into this issue, attempting to view flagged content of all types in a custom view whenever a user attempted to view that page with no content actually flagged yet.

I don't quite follow your setup. Could you explain in a bit more detail please? It sounds like you're talking about a VBO -- is that the case?

Comment #19

hyside CreditAttribution: hyside commented 29 August 2014 at 21:50

I was trying to create a page that showed all content that had been flagged for a given user with links to each of those pieces of flagged content using something like this to create the links

if (isset($_GET['q'])) {
  $current_nid = explode('/',@$_GET['q']);
  $current_nid = empty($current_nid[1]) ? 'tmp' : $current_nid[1];
  print flag_create_link('your_saved_links', $current_nid);
}

Not sure if this helps point you in the right direction?