Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Hi,
I'm working on an enterprise Drupal project in the UK, and I'm currently integrating Superfish. We love the module, it's going to save us a lot of time, but where possible we like to bring stuff up to Drupal coding standards (it makes our automated tools less noisy). So I ran Superfish under the Drupal code-sniffs, and fixed a whole bunch of minor formatting errors. There are a few issues left (line-length, mostly), but I thought I'd start with the easy stuff.
Comment | File | Size | Author |
---|---|---|---|
#4 | superfish-coding-standards-2136511-4.patch | 39.11 KB | dotton |
#1 | superfish-coding-standards-2136511-1.patch | 39.13 KB | dotton |
Comments
Comment #1
dotton CreditAttribution: dotton commentedPatch against the head of 7.x-1.x attached.
Comment #2
Eli-TRunning
phpcs . --standard=Drupal --extensions=module,install,inc
before patch:
After patch:
so this looks really good.
One query, after patch, at line 1760
I don't agree with putting the . instead of an actual description just to get rid of the warning.
Apart from that I can confirm this patch contains no functional changes.
Comment #3
Eli-TComment #4
dotton CreditAttribution: dotton commentedAgreed. I'm not clear on what the values in the $variables array do, so I've stripped the error-suppressing dots.
Comment #5
dotton CreditAttribution: dotton commentedComment #6
Eli-TOK - I've just run PHPCS againt the new patch and two errors are returned but that's much better than artificially suppressing them.
Patch looks good.
Comment #7
mehrpadin CreditAttribution: mehrpadin commentedHey everybody,
Thanks for this :) please check the development release once updated, note I haven't exactly used the patch, but followed everything, gives me no error, so should be fine, thanks again!
Comment #8
Eli-TLooks like there's still no blank line at the end of the file. Apart from that looks good in latest dev.
Comment #9
mehrpadin CreditAttribution: mehrpadin commented