Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow up from #2102777: Allow theme_links to use routes as well as href, we should by now be able to remove this pretty easily. I think anyway...
IIRC it's just the views list controller now that is the issue. Let's try that theory out.
Comment | File | Size | Author |
---|---|---|---|
#10 | 2136641-10.patch | 2.4 KB | damiankloip |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedtrying again to add parent.
Comment #2
YesCT CreditAttribution: YesCT commentedjust related, was noticed in that other issue, but existed before.
Comment #3
YesCT CreditAttribution: YesCT commentedtrying again.
Comment #4
tstoecklerI think there's a double space there after "disable".
Leaving at needs review.
Comment #5
damiankloip CreditAttribution: damiankloip commentedGood spot. Thanks!
Comment #6
dawehnerI tested the views UI manually and things still work with the nice ajax dialogs. Also enable/disable in the view listing still worked.
There are a bunch of #ajax => TRUE, fapi elements, though these ones are not influenced here:
Comment #7
damiankloip CreditAttribution: damiankloip commentedYep indeed; I have removed the code in theme_links() in this patch too. I think the entity reference ones are ok though, as they switch it out for an array in process callbacks. So by the time they are rendered they have a regular ajax array in there.
Basically the only real abuse was/is in views UI.
Comment #8
damiankloip CreditAttribution: damiankloip commentedcome on me.
Comment #9
alexpottComment #10
damiankloip CreditAttribution: damiankloip commentedRerolled. Conflict was due to the conversion to use the CSRF integration.
Comment #11
damiankloip CreditAttribution: damiankloip commentedComment #13
damiankloip CreditAttribution: damiankloip commentedComment #14
damiankloip CreditAttribution: damiankloip commented10: 2136641-10.patch queued for re-testing.
Comment #15
dawehner10: 2136641-10.patch queued for re-testing.
Comment #16
dawehnerComment #17
star-szrComment #18
alexpottCommitted 090d5d1 and pushed to 8.x. Thanks!